One click fix: Dynamically load defaults by executing set_env.sh #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yao, Qing <qing.yao@intel.com>
…essary logs Signed-off-by: Yao, Qing <qing.yao@intel.com>
yao531441
requested review from
chensuyue,
ftian1,
lkk12014402,
lvliang-intel,
minmin-intel and
rbrugaro
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR dynamically loads default values for interactive parameters by executing shell scripts instead of relying on hardcoded defaults. The change addresses CI test failures by sourcing environment variables from set_env.sh scripts during deployment configuration.
- Replaces static text parsing with shell script execution for robust variable extraction
- Removes hardcoded default values from configuration and loads them dynamically from scripts
- Adds --quiet-pull flag to docker-compose commands
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| one_click_deploy/core/utils.py | Replaces regex-based text parsing with shell script execution for environment variable extraction |
| one_click_deploy/core/deployer.py | Integrates dynamic default loading and adds quiet-pull flag to docker-compose |
| one_click_deploy/core/config.py | Removes hardcoded default values from interactive parameter configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
for more information, see https://pre-commit.ci
Signed-off-by: Yao, Qing <qing.yao@intel.com>
…ject/GenAIExamples into yao531441/one_click_fix
Signed-off-by: Yao, Qing <qing.yao@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
ZePan110
approved these changes
Sep 25, 2025
letonghan
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamically load defaults by executing set_env.sh on one click deploy scripts.
Issues
CI test fail cases
https://github.com/opea-project/GenAIExamples/actions/runs/17874502052/job/51091036509
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
CI