Skip to content

Conversation

@zehao-intel
Copy link
Collaborator

@zehao-intel zehao-intel commented Jun 13, 2024

Description

Refactor Translation example to the new structure

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a

Tests

n/a

Signed-off-by: zehao-intel <zehao.huang@intel.com>
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

@zehao-intel
Copy link
Collaborator Author

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now.
Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

@daisy-ycguo
Copy link
Collaborator

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now. Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

It is not expected. I might miss this workload. Please help to add it to the right line. Thank you.

@zehao-intel
Copy link
Collaborator Author

Please move "Translation" from not supported case line to the upper case line in this file: .github/workflows/scripts/build_push.sh. The manifest e2e test will pass. Thank you.

Hi, @daisy-ycguo . Thanks for reminding me. I have made the modification now. Besides, I notice that "SearchQnA" is both in the not-supported-case line and the upper-case line. Do you know if it is expected?

It is not expected. I might miss this workload. Please help to add it to the right line. Thank you.

Sure, do you want me to remove it from the not-supported-case line or the upper-case line?

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>
zehao-intel and others added 5 commits June 19, 2024 17:32
Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
@chensuyue chensuyue force-pushed the zehao/translation branch from 2c36250 to 34b2469 Compare June 20, 2024 02:40
zehao-intel and others added 9 commits June 21, 2024 09:58
Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: zehao-intel <zehao.huang@intel.com>
@zehao-intel zehao-intel requested a review from WenjiaoYue June 25, 2024 02:04
…e. (#317)

* Add image build job in docker compose e2e gaudi test in CI (#305)

Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>

* Add gpu support for ChatQnA (#308)

* add gpu support for chatqna

Signed-off-by: Ding, Ke <ke.ding@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Ding, Ke <ke.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Update ChatQnA for Xeon docker_compose.yaml to fix downloads failing (#310)

* Update docker_compose

* Updated docker_compose

* Updated docker_compose

* Add build docker image option for test scripts (#312)

Signed-off-by: chensuyue <suyue.chen@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>
Signed-off-by: Ding, Ke <ke.ding@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
Co-authored-by: Ying Chun Guo <yingchun.guo@intel.com>
Co-authored-by: Ke Ding <ke.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <william.fowler@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
@zehao-intel zehao-intel merged commit 409c723 into main Jun 25, 2024
@zehao-intel zehao-intel deleted the zehao/translation branch June 25, 2024 05:22
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
* Refactor Translation Example

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* support e2s test

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* fix test ip_address

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* update test scripts

Signed-off-by: chensuyue <suyue.chen@intel.com>

* update test scripts

Signed-off-by: chensuyue <suyue.chen@intel.com>

* for test

Signed-off-by: chensuyue <suyue.chen@intel.com>

* fix readme and dockerfile

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* revert test code

Signed-off-by: chensuyue <suyue.chen@intel.com>

* remove gaudi test update

Signed-off-by: chensuyue <suyue.chen@intel.com>

* bug fix

Signed-off-by: chensuyue <suyue.chen@intel.com>

* fix test xeon

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* modify mega check

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* fix ui

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* fix ut network

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* fix network

Signed-off-by: zehao-intel <zehao.huang@intel.com>

* Modify the corresponding format according to the backend new structure. (opea-project#317)

* Add image build job in docker compose e2e gaudi test in CI (opea-project#305)

Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>

* Add gpu support for ChatQnA (opea-project#308)

* add gpu support for chatqna

Signed-off-by: Ding, Ke <ke.ding@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Ding, Ke <ke.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Update ChatQnA for Xeon docker_compose.yaml to fix downloads failing (opea-project#310)

* Update docker_compose

* Updated docker_compose

* Updated docker_compose

* Add build docker image option for test scripts (opea-project#312)

Signed-off-by: chensuyue <suyue.chen@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>
Signed-off-by: Ding, Ke <ke.ding@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
Co-authored-by: Ying Chun Guo <yingchun.guo@intel.com>
Co-authored-by: Ke Ding <ke.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <william.fowler@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>

---------

Signed-off-by: zehao-intel <zehao.huang@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: Yingchun Guo <yingchun.guo@intel.com>
Signed-off-by: Ding, Ke <ke.ding@intel.com>
Signed-off-by: WenjiaoYue <wenjiao.yue@intel.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Co-authored-by: WenjiaoYue <wenjiao.yue@intel.com>
Co-authored-by: Ying Chun Guo <yingchun.guo@intel.com>
Co-authored-by: Ke Ding <ke.ding@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Fowler <william.fowler@intel.com>
Co-authored-by: lvliang-intel <liang1.lv@intel.com>
JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this pull request Jan 28, 2025
Fix issue opea-project#287

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants