Skip to content

Conversation

@ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Jun 14, 2024

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@ZePan110 ZePan110 requested a review from chensuyue June 14, 2024 07:45
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this workflow belongs to GenAIExamples not GenAICompos.

@chensuyue
Copy link
Collaborator

I wonder why this workflow belongs to GenAIExamples not GenAIComps.

We propose to setup checking workflow on Both GenAIExamples and GenAIComps. In GenAIExamples, we mainly checking for typos, in GenAIComps we mainly checking for Dockerfile path change in PR.

@daisy-ycguo
Copy link
Collaborator

I wonder why this workflow belongs to GenAIExamples not GenAIComps.

We propose to setup checking workflow on Both GenAIExamples and GenAIComps. In GenAIExamples, we mainly checking for typos, in GenAIComps we mainly checking for Dockerfile path change in PR.

I think this workflow is to checking for Dockerfile path in GenAICompos. Correct me if I'm wrong.

@chensuyue
Copy link
Collaborator

I wonder why this workflow belongs to GenAIExamples not GenAIComps.

We propose to setup checking workflow on Both GenAIExamples and GenAIComps. In GenAIExamples, we mainly checking for typos, in GenAIComps we mainly checking for Dockerfile path change in PR.

I think this workflow is to checking for Dockerfile path in GenAICompos. Correct me if I'm wrong.

This workflow is checking the Dockerfile path in GenAIExamples readme can be found correctly in GenAIComps, to avoid typos.
We will add another workflow in GenAIComps PR to make sure the Dockerfile path change can be update parallel in GenAIExamples.

@ZePan110 ZePan110 force-pushed the Path_detection branch 2 times, most recently from b8ab944 to 06ea16f Compare June 14, 2024 09:39
@ZePan110 ZePan110 force-pushed the Path_detection branch 10 times, most recently from a130ee2 to d36fcc1 Compare June 14, 2024 10:48
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@chensuyue chensuyue merged commit c3b641f into main Jun 14, 2024
@chensuyue chensuyue deleted the Path_detection branch June 14, 2024 11:19
ZePan110 added 5 commits June 14, 2024 23:39
Signed-off-by: zepan <ze.pan@intel.com>
Signed-off-by: zepan <ze.pan@intel.com>
Signed-off-by: zepan <ze.pan@intel.com>
Signed-off-by: zepan <ze.pan@intel.com>
Signed-off-by: zepan <ze.pan@intel.com>
Spycsh pushed a commit to Spycsh/GenAIExamples that referenced this pull request Jun 19, 2024
Signed-off-by: zepan <ze.pan@intel.com>
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
Signed-off-by: zepan <ze.pan@intel.com>
wangkl2 pushed a commit to wangkl2/GenAIExamples that referenced this pull request Dec 11, 2024
* first code of business safety classifier

* allow strategy options and update readme

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* disable ray for ml strategy and update test script

* add log to pii test

Signed-off-by: minmin-intel <minmin.hou@intel.com>

* update logging in test gaurdrail

* rm llm strategy and change url in test

Signed-off-by: minmin-intel <minmin.hou@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* delete file check in test and update readme

Signed-off-by: minmin-intel <minmin.hou@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: minmin-intel <minmin.hou@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this pull request Jan 28, 2025
* GMC: Add GPU support for GMC.

Enable NVIDIA GPU support for GMC, including sequence and switch
mode. Note that switch mode may fail due to NO enough GPU memory.

Signed-off-by: PeterYang12 <yuhan.yang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants