Skip to content

Conversation

@Ruoyu-y
Copy link
Contributor

@Ruoyu-y Ruoyu-y commented Jul 9, 2024

Description

Fixing minor issues in GMC documentation

  • align deployment name in doc with the one in yaml file
  • add the missing namespace in the command

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a

Tests

n/a

@Ruoyu-y
Copy link
Contributor Author

Ruoyu-y commented Jul 9, 2024

@zhlsunshine add a minor fix here. Can you help add the reviewers for this? Thx.

@zhlsunshine
Copy link

@zhlsunshine add a minor fix here. Can you help add the reviewers for this? Thx.

Hi @Ruoyu-y, sorry for missing this, so I submitted a PR#409 for it. Could you check it and handle the CI pipeline error, we can use your PR for the documentation, and I will close mine. Is it okay?

* align deployment name
* add the missing namespace in the command

Signed-off-by: Ruoyu Ying <ruoyu.ying@intel.com>
Copy link

@zhlsunshine zhlsunshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chensuyue chensuyue merged commit d994618 into opea-project:main Jul 18, 2024
yogeshmpandey pushed a commit to hteeyeoh/GenAIExamples that referenced this pull request Aug 12, 2024
Signed-off-by: Ruoyu Ying <ruoyu.ying@intel.com>
JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this pull request Jan 28, 2025
* add UT for reconcile filters

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* remove useless code

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* update tests

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* debug CI/CD failed

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* skip use pod_count in e2e's check_gmc_status, the pod_count is not acurrate sometimes when terninating pod is not cleared but counted

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* better than hardcode

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* count the pods right

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

---------

Signed-off-by: KfreeZ <kefei.zhang@intel.com>
JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this pull request Jan 28, 2025
* fix a badcommit in opea-project#383

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* fix a badcommit in opea-project#383

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

* fix a badcommit in opea-project#383

Signed-off-by: KfreeZ <kefei.zhang@intel.com>

---------

Signed-off-by: KfreeZ <kefei.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants