Align parameters for "max_token, repetition_penalty,presence_penalty,frequency_penalty" #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
kevinintel
approved these changes
Sep 5, 2024
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
for more information, see https://pre-commit.ci
XinyaoWa
changed the title
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
XinyaoWa
changed the title
lvliang-intel
approved these changes
Sep 19, 2024
polszewska
pushed a commit
to polszewska/GenAIExamples
that referenced
this pull request
Sep 20, 2024
…frequency_penalty" (opea-project#726) Signed-off-by: Xinyao Wang <xinyao.wang@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align with PR in GenAIComps opea-project/GenAIComps#608
Comps: LLMs use max_tokens, others use max_new_tokens
Examples(keep unchanged): Most use max_tokens
Issues
#673