bugfix json #1025
Merged
bugfix json #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in JSON deserialization for xstring types by adding proper base64 decoding support. The fix ensures that xstring values can be correctly serialized to and deserialized from JSON format.
- Added base64 decoding for xstring types during deserialization
- Added test case to verify xstring serialization/deserialization identity
- Updated @abaplint dependencies to version 2.12.7
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/json/#ui2#cl_json.clas.abap | Added xstring deserialization logic with base64 decoding and removed an empty line |
| src/json/#ui2#cl_json.clas.testclasses.abap | Added test method to verify xstring serialization/deserialization round-trip |
| package.json | Updated @abaplint/runtime and @abaplint/transpiler-cli to version 2.12.7 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Performance test results:
Updated: 2025-10-24T09:17:17.476Z SHA: 5e53810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.