Skip to content

Conversation

@xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jan 21, 2022

Signed-off-by: xuezhaojun zxue@redhat.com

Relevant issue: open-cluster-management-io/registration-operator#157

@openshift-ci openshift-ci bot requested review from mdelder and qiujian16 January 21, 2022 02:29
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch from b8cfacd to 76e2c3a Compare January 21, 2022 03:19
@xuezhaojun xuezhaojun requested a review from qiujian16 January 21, 2022 03:20
@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch 3 times, most recently from 5872843 to f7ba9e8 Compare January 21, 2022 04:27
@xuezhaojun xuezhaojun requested a review from qiujian16 January 21, 2022 04:28
@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch from f7ba9e8 to 6d5c676 Compare January 27, 2022 14:36
@xuezhaojun xuezhaojun changed the title add apiservice target ports Add registraiton & work webhook configration for detached mode Jan 27, 2022
@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch 2 times, most recently from eb40272 to 5050ee6 Compare February 7, 2022 06:14
@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch from 5050ee6 to 3c82c57 Compare February 7, 2022 08:45
@xuezhaojun xuezhaojun requested a review from qiujian16 February 7, 2022 08:46
Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun xuezhaojun force-pushed the add-apiservice-target-port branch from 3c82c57 to e0761f6 Compare February 7, 2022 09:30
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2022
@xuezhaojun xuezhaojun requested a review from qiujian16 February 7, 2022 13:55
@openshift-merge-robot openshift-merge-robot merged commit 280cf8e into open-cluster-management-io:main Feb 7, 2022
@xuezhaojun xuezhaojun deleted the add-apiservice-target-port branch October 17, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants