Skip to content

Set omitempty on the ManifestWork UpdateStrategy field #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Set omitempty on the ManifestWork UpdateStrategy field #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ spec:
description: Resource is the resource name of the Kubernetes resource.
type: string
updateStrategy:
description: UpdateStrategy defines the strategy to update this manifest. UpdateStrategy is Update if it is not set, optional
description: UpdateStrategy defines the strategy to update this manifest. UpdateStrategy is Update if it is not set.
type: object
required:
- type
Expand Down
6 changes: 3 additions & 3 deletions work/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ type ManifestConfigOption struct {
FeedbackRules []FeedbackRule `json:"feedbackRules,omitempty"`

// UpdateStrategy defines the strategy to update this manifest. UpdateStrategy is Update
// if it is not set,
// optional
UpdateStrategy *UpdateStrategy `json:"updateStrategy"`
// if it is not set.
// +optional
UpdateStrategy *UpdateStrategy `json:"updateStrategy,omitempty"`
}

// ManifestWorkExecutor is the executor that applies the resources to the managed cluster. i.e. the
Expand Down
2 changes: 1 addition & 1 deletion work/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion work/v1alpha1/0000_00_work.open-cluster-management.io_placemanifestworks.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ spec:
description: Resource is the resource name of the Kubernetes resource.
type: string
updateStrategy:
description: UpdateStrategy defines the strategy to update this manifest. UpdateStrategy is Update if it is not set, optional
description: UpdateStrategy defines the strategy to update this manifest. UpdateStrategy is Update if it is not set.
type: object
required:
- type
Expand Down