Skip to content

Feat: clusteradm addon disable command for disable specified addon #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2022
Merged

Feat: clusteradm addon disable command for disable specified addon #102

merged 4 commits into from
Jan 25, 2022

Conversation

@ycyaoxdu
Copy link
Member

@ycyaoxdu ycyaoxdu commented Jan 5, 2022

Signed-off-by: ycyaoxdu yaoyuchen0626@163.com

Add a subcommand diable to command addon for enhance the new feature 3 which mentioned in #87

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 January 5, 2022 11:46
@ycyaoxdu ycyaoxdu force-pushed the add-command-addon-disable branch from e2381c9 to 6dab314 Compare January 6, 2022 05:15
@ycyaoxdu ycyaoxdu changed the title Feat: clusteradm addon disable command for disable specified addon [WIP] Feat: clusteradm addon disable command for disable specified addon Jan 14, 2022
@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Jan 17, 2022

something goes wrong. https://github.com/open-cluster-management-io/clusteradm/runs/4836202667?check_suite_focus=true#step:4:65
It seems like a bug ,need to be solved.
i will check it out first.

@ycyaoxdu ycyaoxdu changed the title [WIP] Feat: clusteradm addon disable command for disable specified addon Feat: clusteradm addon disable command for disable specified addon Jan 17, 2022
@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Jan 17, 2022

/hold

@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Jan 21, 2022

solved by this change https://github.com/open-cluster-management-io/clusteradm/pull/107/files#diff-57fb64e41aecc769c85303b36a57d69f497e6ba8390f3352a4f1485a029ca1d1R17

something goes wrong. https://github.com/open-cluster-management-io/clusteradm/runs/4836202667?check_suite_focus=true#step:4:65 It seems like a bug ,need to be solved. i will check it out first.

@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Jan 21, 2022

/unhold

qiujian16
qiujian16 reviewed Jan 24, 2022
View reviewed changes
qiujian16
qiujian16 reviewed Jan 24, 2022
View reviewed changes
qiujian16
qiujian16 reviewed Jan 24, 2022
View reviewed changes
@ycyaoxdu ycyaoxdu force-pushed the add-command-addon-disable branch from 54dd3d8 to 9afcb4a Compare January 25, 2022 06:09
@ycyaoxdu ycyaoxdu mentioned this pull request Jan 25, 2022
Merged
@ycyaoxdu ycyaoxdu force-pushed the add-command-addon-disable branch from 9afcb4a to 40a1d5b Compare January 25, 2022 07:11
@ycyaoxdu ycyaoxdu mentioned this pull request Jan 25, 2022
Merged
qiujian16
qiujian16 reviewed Jan 25, 2022
View reviewed changes
@ycyaoxdu ycyaoxdu force-pushed the add-command-addon-disable branch from 40a1d5b to 9e49d92 Compare January 25, 2022 08:09
@ycyaoxdu
addon enable: allow certain addon to be deployed
6a2800d 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu
addon disable: allow certain addon to be undeployed
4789d70 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu
add integration test for clusteradm addon disable
ec7df62 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu
replace map by set in apimachinery, removed flag namespace
4df06b7 
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu ycyaoxdu force-pushed the add-command-addon-disable branch from 9e49d92 to 4df06b7 Compare January 25, 2022 13:55
@ycyaoxdu ycyaoxdu requested a review from qiujian16 January 25, 2022 14:10
@qiujian16
Copy link
Member

qiujian16 commented Jan 25, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2be8505 into open-cluster-management-io:main Jan 25, 2022
@ycyaoxdu ycyaoxdu deleted the add-command-addon-disable branch January 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itdove itdove Awaiting requested review from itdove

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@qiujian16 qiujian16

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ycyaoxdu @qiujian16 @openshift-merge-robot