Skip to content

Conversation

@ycyaoxdu
Copy link
Member

@ycyaoxdu ycyaoxdu commented Jan 6, 2022

Signed-off-by: ycyaoxdu yaoyuchen0626@163.com

Modify the integration test because of the directory refactor in this PR #101.
Modify tests for command clusteradm addon enable.

Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@openshift-ci openshift-ci bot requested review from itdove and qiujian16 January 6, 2022 08:43
@xauthulei
Copy link
Member

@qiujian16 , if we could merge this PR, there are more local error warning, Thanks

unknown field values in struct literal
undeclared name: Values
...

@qiujian16
Copy link
Member

I think there are still some questions in this PR?

@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Jan 10, 2022

@qiujian16 , if we could merge this PR, there are more local error warning, Thanks

unknown field values in struct literal
undeclared name: Values
...

can you offer me more information about these errors and warnings? Thank you. @xauthulei

Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
@ycyaoxdu
Copy link
Member Author

after fix , the former integration test works.

@qiujian16
Copy link
Member

/approve
/lgtm

thanks merge this to ensure we have a passed test.

@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ae629b1 into open-cluster-management-io:main Jan 14, 2022
@ycyaoxdu ycyaoxdu deleted the modify-integration-test branch January 19, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants