Skip to content

change method and veriables to public scope in clusetset_unbind command. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

change method and veriables to public scope in clusetset_unbind command. #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cmd/clusterset/unbind/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ var example = `

// NewCmd...
func NewCmd(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, streams genericclioptions.IOStreams) *cobra.Command {
o := newOptions(clusteradmFlags, streams)
o := NewOptions(clusteradmFlags, streams)

cmd := &cobra.Command{
Use: "unbind",
Expand All @@ -34,10 +34,10 @@ func NewCmd(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, stream
if err := o.complete(c, args); err != nil {
return err
}
if err := o.validate(); err != nil {
if err := o.Validate(); err != nil {
return err
}
if err := o.run(); err != nil {
if err := o.Run(); err != nil {
return err
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/clusterset/unbind/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
return nil
}

func (o *Options) validate() (err error) {
func (o *Options) Validate() (err error) {
if len(o.Namespace) == 0 {
return fmt.Errorf("namespace name must be specified in --namespace")
}
return nil
}

func (o *Options) run() (err error) {
func (o *Options) Run() (err error) {
restConfig, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/clusterset/unbind/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Options struct {
Namespace string
}

func newOptions(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, streams genericclioptions.IOStreams) *Options {
func NewOptions(clusteradmFlags *genericclioptionsclusteradm.ClusteradmFlags, streams genericclioptions.IOStreams) *Options {
return &Options{
ClusteradmFlags: clusteradmFlags,
Streams: streams,
Expand Down