allow install hub-addon specify ns #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
related issue #186 |
ycyaoxdu
changed the title
ycyaoxdu
force-pushed
the
enable-install-hub-addon-namespace
branch
3 times, most recently
from
d0ac49e to
fc17b85
Compare
ycyaoxdu
changed the title
Member
Author
|
/assign @qiujian16 |
qiujian16
reviewed
Oct 9, 2022
pkg/cmd/install/hubaddon/exec.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| _, err = kubeClient.CoreV1().Namespaces().Get(context.TODO(), o.values.Namespace, metav1.GetOptions{}) |
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
ycyaoxdu
force-pushed
the
enable-install-hub-addon-namespace
branch
from
fc17b85 to
dc103e0
Compare
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ycyaoxdu yaoyuchen0626@163.com