Fix issue #52 - added image rending to the join command #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the 1st commit message: support image rendring for join command added image rending to the join command Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
…dm into join-render-image
qiujian16
reviewed
Dec 9, 2021
.vscode/launch.json
Outdated
| @@ -0,0 +1,20 @@ | |||
| { | |||
| // Use IntelliSense to learn about possible attributes. | |||
Member
There was a problem hiding this comment.
would you remove this .vscode?
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
qiujian16
reviewed
Dec 9, 2021
| spec: | ||
| registrationImagePullSpec: quay.io/open-cluster-management/registration | ||
| workImagePullSpec: quay.io/open-cluster-management/work | ||
| registrationImagePullSpec: {{ .ImageRegistry.Registry }}/registration |
Member
There was a problem hiding this comment.
sorry to ask again...but the version should be added here also.
Signed-off-by: Ilan Pinto <ilpinto@redhat.com>
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ilan-pinto, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st commit message:
support image rendering for join command
added image rending to the join command
Signed-off-by: Ilan Pinto ilpinto@redhat.com