-
Notifications
You must be signed in to change notification settings - Fork 7
🌱 update fleetconfig API to support configuring add-ons #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 4 commits into
open-cluster-management-io:main
from
arturshadnik:feat/addon-api
Jul 15, 2025
Merged
🌱 update fleetconfig API to support configuring add-ons #26
openshift-merge-bot
merged 4 commits into
open-cluster-management-io:main
from
arturshadnik:feat/addon-api
Jul 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arturshadnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ahmad-ibra
reviewed
Jul 15, 2025
ahmad-ibra
reviewed
Jul 15, 2025
ahmad-ibra
reviewed
Jul 15, 2025
ahmad-ibra
reviewed
Jul 15, 2025
ahmad-ibra
reviewed
Jul 15, 2025
9ff0295 to
527ea1c
Compare
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: whitespace Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Co-authored-by: Ahmad Malik Ibrahim <ahm.ibr@hotmail.com> Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: Update fleetconfig-controller/api/v1alpha1/fleetconfig_types.go Co-authored-by: Ahmad Malik Ibrahim <ahm.ibr@hotmail.com> Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: update chart to reflect field rename Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: update chart to reflect field rename Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Co-authored-by: Ahmad Malik Ibrahim <ahm.ibr@hotmail.com> Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: regenerate Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Co-authored-by: Ahmad Malik Ibrahim <ahm.ibr@hotmail.com> Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com> chore: regenerate Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
527ea1c to
57b976c
Compare
Member
|
/lgtm |
87b017c
into
open-cluster-management-io:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Fleetconfig Controller can support creating and installing arbitrary ManagedClusterAddOns by leveraging the
clusteradm addoncommand.Changes
This PR proposes the API changes for supporting add-ons. The following changes are added.
FleetConfig.Spec.AddOnsclusteradm addon createcommand.yamlfile can be used directly, and OCI artifacts would be downloaded first and written to a temp file.FleetConfig.Spec.AddOns[*].Name, and the value will be either the URL or the raw manifests to be consumed by the controllerFleetConfig.Spec.Spokes[*].AddOnsinstallNamespaceand adding annotations, in line with what theclusteradm addon enablecommand supportsFleetConfig.Spec.Spokes[*].AddOns[*].Namecorresponds to one of the top-level add-ons, or a default add-on (TBD in a followup)TODO
This PR does not introduce any changes to the controller code. The following work will be done in followup PRs:
a. Handling the full lifecycle of the AddOnTemplates and other Hub resources
b. Handling the full lifecycle of ManagedClusterAddOns as spoke clusters are joined and unjoined