🐛 set owner meta on addon resources to prevent deleting out-of-band addons #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
"addon.open-cluster-management.io/managedBy": fleetconfig-controllerlabel to anyClusterManagementAddOn,AddOnTemplateandManagedClusterAddOnthat is created by FCCThis will prevent accidentally deleting addons that are created either manually (helm charts, etc), or using
clusteradm.Sanity testing
Note: argocd agent addon does not seem to be designed to work with a hub-as-spoke cluster, so it's best to not register the hub as a spoke, or modify the placement to not target the hub-as-spoke