Skip to content

Conversation

@arturshadnik
Copy link
Member

Description

This PR:

  • adds a "addon.open-cluster-management.io/managedBy": fleetconfig-controller label to any ClusterManagementAddOn, AddOnTemplate and ManagedClusterAddOn that is created by FCC
  • uses this label to filter the resources when deciding what to delete/disable

This will prevent accidentally deleting addons that are created either manually (helm charts, etc), or using clusteradm.

Sanity testing

Note: argocd agent addon does not seem to be designed to work with a hub-as-spoke cluster, so it's best to not register the hub as a spoke, or modify the placement to not target the hub-as-spoke

…-band addons

Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arturshadnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmad-ibra
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 49fa89f into open-cluster-management-io:main Aug 15, 2025
7 checks passed
@arturshadnik arturshadnik deleted the fix/addon-owner branch August 20, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants