✨ helm values hardening; user-configured env; optional v1alpha1 disable #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isable Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
WalkthroughAdds a feature flag to enable legacy FleetConfig controllers and conditionally render the legacy FleetConfig CRD; wires the flag through CLI, manager options, Helm values/templates, DevSpace, a CRD-formatting/move script, and test CRD discovery paths. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
fleetconfig-controller/Makefile(1 hunks)fleetconfig-controller/charts/fleetconfig-controller/README.md(2 hunks)fleetconfig-controller/charts/fleetconfig-controller/templates/crd-fleetconfig.open-cluster-management.io_fleetconfigs.yaml(2 hunks)fleetconfig-controller/charts/fleetconfig-controller/templates/deployment.yaml(2 hunks)fleetconfig-controller/charts/fleetconfig-controller/templates/ocm/fcc-addon/addon-template.yaml(1 hunks)fleetconfig-controller/charts/fleetconfig-controller/values.yaml(3 hunks)fleetconfig-controller/cmd/main.go(1 hunks)fleetconfig-controller/cmd/manager/manager.go(3 hunks)fleetconfig-controller/devspace.yaml(5 hunks)fleetconfig-controller/hack/format_legacy_crds.sh(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-27T21:58:32.141Z
Learnt from: arturshadnik
PR: open-cluster-management-io/lab#58
File: fleetconfig-controller/charts/fleetconfig-controller/README.md:155-155
Timestamp: 2025-08-27T21:58:32.141Z
Learning: In the open-cluster-management-io/lab repository, the fleetconfig-controller follows a workflow where chart version bumps (in README.md and values.yaml) are included in PRs before the corresponding Docker image exists. The Docker image is built and pushed automatically via GitHub release workflows after the PR is merged and tagged, making the referenced version available.
Applied to files:
fleetconfig-controller/hack/format_legacy_crds.sh
🧬 Code graph analysis (1)
fleetconfig-controller/cmd/manager/manager.go (2)
fleetconfig-controller/internal/controller/v1alpha1/fleetconfig_controller.go (1)
FleetConfigReconciler(58-62)fleetconfig-controller/api/v1alpha1/fleetconfig_webhook.go (1)
SetupFleetConfigWebhookWithManager(38-43)
🪛 YAMLlint (1.37.1)
fleetconfig-controller/charts/fleetconfig-controller/templates/crd-fleetconfig.open-cluster-management.io_fleetconfigs.yaml
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: e2e (fleetconfig-controller) / e2e
- GitHub Check: e2e (fleetconfig-controller) / e2e
- GitHub Check: test (fleetconfig-controller) / Ensure PR is reviewable & run tests
- GitHub Check: test (fleetconfig-controller) / Run Helm Chart Tests
- GitHub Check: test (fleetconfig-controller) / Ensure PR is reviewable & run tests
...leetconfig-controller/templates/crd-fleetconfig.open-cluster-management.io_fleetconfigs.yaml
Show resolved
Hide resolved
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
fleetconfig-controller/api/v1alpha1/webhook_suite_test.go(1 hunks)fleetconfig-controller/hack/format_legacy_crds.sh(1 hunks)fleetconfig-controller/internal/controller/v1alpha1/suite_test.go(1 hunks)fleetconfig-controller/internal/controller/v1beta1/suite_test.go(1 hunks)fleetconfig-controller/internal/webhook/v1beta1/webhook_suite_test.go(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- fleetconfig-controller/hack/format_legacy_crds.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: e2e (fleetconfig-controller) / e2e
- GitHub Check: e2e (fleetconfig-controller) / e2e
- GitHub Check: test (fleetconfig-controller) / Ensure PR is reviewable & run tests
- GitHub Check: test (fleetconfig-controller) / Ensure PR is reviewable & run tests
- GitHub Check: test (fleetconfig-controller) / Run Helm Chart Tests
🔇 Additional comments (3)
fleetconfig-controller/internal/controller/v1alpha1/suite_test.go (1)
78-81: LGTM: Consistent CRD path expansion for v1alpha1 tests.The expansion of CRD search paths is consistent with the v1beta1 controller test suite and properly supports testing of legacy v1alpha1 CRDs from the
config/crdsdirectory.fleetconfig-controller/internal/webhook/v1beta1/webhook_suite_test.go (1)
89-92: LGTM: Consistent webhook test CRD configuration.The CRD path expansion is consistent with the v1alpha1 webhook test suite and properly supports the conditional CRD installation feature.
fleetconfig-controller/api/v1alpha1/webhook_suite_test.go (1)
82-85: Approve: consistent ErrorIfCRDPathMissing:false in webhook tests ErrorIfCRDPathMissing is set to false across both webhook suites while controller suites use true; no change required.
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
Signed-off-by: Artur Shad Nik <arturshadnik@gmail.com>
TylerGillson
approved these changes
Oct 10, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arturshadnik, TylerGillson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b9665a0
into
open-cluster-management-io:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"RuntimeDefault"for enhanced securitytemplates/so that it can be disabled conditionally (crds/dir doesnt support templating)Summary by CodeRabbit
New Features
Configuration
Documentation
Chores
Tests