fix: update the fcc /hack/dev/spoke.yaml to use latest v1beta1 fields

[ahmad-ibra]

Running through the dev setup instructions yielded errors prior to this change.

Summary by CodeRabbit

• Chores
  • Updated version control configuration file exclusions for development environment tools
  • Reorganized cleanup configuration parameters in deployment specifications

[coderabbitai]

Walkthrough

This PR modifies two files: adds a Neovim directory ignore rule to .gitignore and restructures the klusterlet configuration in spoke.yaml by relocating purge operator settings into a new cleanupConfig block.

Changes

Cohort / File(s)	Summary
Editor/IDE Configuration .gitignore	Added ignore rule for Neovim directory (.nvim/) in the Editor/IDE section
Kubernetes Configuration fleetconfig-controller/hack/dev/spoke.yaml	Restructured klusterlet spec by moving purgeOperator: true into new cleanupConfig block containing purgeAgentNamespace, purgeKubeconfigSecret, and purgeKlusterletOperator settings

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• spoke.yaml: Verify the restructured YAML maintains intended behavior—ensure the new cleanupConfig location and nested properties function as designed in the fleetconfig-controller system
• Integration: Confirm no other configuration files or documentation reference the old purgeOperator location that may require corresponding updates

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: updating spoke.yaml to use latest v1beta1 fields, which matches the primary modification in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dda3410 and 88c2b68.

📒 Files selected for processing (2)

• .gitignore (1 hunks)
• fleetconfig-controller/hack/dev/spoke.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (7)

📚 Learning: 2025-09-25T23:18:41.573Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 69
File: fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go:125-133
Timestamp: 2025-09-25T23:18:41.573Z
Learning: In the fleetconfig-controller spoke deletion flow, SpokeCleanupFinalizer is always removed before HubCleanupFinalizer. This means that checking for the existence of HubCleanupFinalizer in the deletion logic is sufficient regardless of cluster type, as any SpokeCleanupFinalizer would have already been removed by the time the hub cleanup runs.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-12T22:46:57.106Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 59
File: fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go:328-331
Timestamp: 2025-09-12T22:46:57.106Z
Learning: In fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go, nil klusterletValues returned by mergeKlusterletValues is a valid state, not an error condition. The downstream prepareKlusterletValuesFile function properly handles nil values by returning early, making additional nil checks unnecessary and potentially harmful to the intended flow.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-22T19:16:34.109Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 59
File: fleetconfig-controller/internal/webhook/v1beta1/validation.go:103-121
Timestamp: 2025-09-22T19:16:34.109Z
Learning: In the open-cluster-management-io/lab repository's fleetconfig-controller v1beta1 API, the Klusterlet field in SpokeSpec is defined as a struct value (Klusterlet Klusterlet), not a pointer (*Klusterlet), so direct field access like Klusterlet.Annotations is safe without nil checks. The Klusterlet struct does not contain a Source field.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-12T22:46:57.106Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 59
File: fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go:328-331
Timestamp: 2025-09-12T22:46:57.106Z
Learning: In fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go, nil klusterletValues returned by mergeKlusterletValues is a valid state, not an error condition. The downstream prepareKlusterletValuesFile function properly handles nil values by returning early with (nil, nil, nil), making additional nil checks unnecessary and potentially harmful to the intended flow.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-25T23:31:11.630Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 69
File: fleetconfig-controller/charts/fleetconfig-controller/templates/ocm/fcc-addon/addon-template.yaml:110-112
Timestamp: 2025-09-25T23:31:11.630Z
Learning: The fleetconfig-controller-manager spoke agent requires create/update/patch/delete permissions on CustomResourceDefinitions because `clusteradm upgrade klusterlet` operations need create/update permissions and cleanup operations require delete permissions for proper lifecycle management.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-12T22:46:57.106Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 59
File: fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go:328-331
Timestamp: 2025-09-12T22:46:57.106Z
Learning: In fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go, nil klusterletValues returned by mergeKlusterletValues is a valid state, not an error condition. The downstream functions (prepareKlusterletValuesFile and hash.ComputeHash) properly handle nil values - prepareKlusterletValuesFile returns early with (nil, nil, nil) and hash.ComputeHash uses ZeroNil: true option to handle nil as zero values.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

📚 Learning: 2025-09-12T22:46:57.106Z

Learnt from: arturshadnik
Repo: open-cluster-management-io/lab PR: 59
File: fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go:328-331
Timestamp: 2025-09-12T22:46:57.106Z
Learning: In fleetconfig-controller/internal/controller/v1beta1/spoke_controller.go, nil klusterletValues returned by mergeKlusterletValues is a valid state, not an error condition. The downstream functions handle nil properly: prepareKlusterletValuesFile returns early with (nil, nil, nil) for nil values, and hash.ComputeHash uses ZeroNil: true option to treat nil as zero values when computing hashes.

Applied to files:

• fleetconfig-controller/hack/dev/spoke.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: e2e (fleetconfig-controller) / e2e
• GitHub Check: test (fleetconfig-controller) / Ensure PR is reviewable & run tests
• GitHub Check: e2e (fleetconfig-controller) / e2e

🔇 Additional comments (2)

.gitignore (1)

41-41: LGTM!

Adding .nvim/ to the Editor/IDE section is appropriate and follows the existing pattern for other editor directories like .vscode/ and .idea/.

fleetconfig-controller/hack/dev/spoke.yaml (1)

29-33: Verify v1beta1 schema alignment for cleanupConfig structure.

The restructuring from purgeOperator: true to a cleanupConfig block with granular fields (purgeAgentNamespace, purgeKubeconfigSecret, purgeKlusterletOperator) suggests an API schema migration to v1beta1. Confirm that:

1. The cleanupConfig block and its three fields match the current v1beta1 Klusterlet API schema
2. These specific field names are correct and that the values and semantics align with the previous purgeOperator behavior
3. This configuration change resolves the dev setup errors mentioned in the PR description

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmad-ibra, TylerGillson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TylerGillson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment