Add Breakout Board devices #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed enableDevice to configureDevice
- Update the pointers to be vectors of smart pointers. See issue-5 for more details
- Make raw pointers private - Remove unused DataBuffer* - Removed excess calls to addSourceBuffers - Update samplesPerSecond for MemoryMonitor
- Remove empty destructors - Modify comments so they accurately reflect what the class / method does
- Note: Currently this does not write data frames to the device. This will be added in a later commit
- Updated the patterns used by the breakout board devices for instantiating the device (Onix1 as a shared pointer, and updates to updateSettings())
- Note: This is not currently saving the digital data as events. This will be added later
- These devices are hard-coded with default settings and should not be changed - Reformatted how found vs. selected maps are compared to provide more flexibility for these "missing" interfaces
- Modify the interface and backend so that there is a checkbox the user can check that either ties the clock to the acquisition status, or is free-running Miscellaneous updates: - Use emplace_back instead of push_back - Remove info/name labels from interfaces that don't need them=
- Removed UI elements from AnalogIOInterface, now hard-coded to be in Volts, with a range of +/- 10 Volts - Fixed OutputClock register writes, now they correctly set parameters chosen in the settings interface - Added manual update to the settings of specific devices. Note: This infrastructure will be modified at a later date to be less brittle - Unified the location of the enable button across tabs - Removed additional context resets that were leading to slow-downs in reading frames
jonnew
approved these changes
Apr 3, 2025
|
I dunno what happened to the comments I made o nthi |
- Change to using #pragma instead of #ifndef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all of the devices from the breakout board. That includes all UI elements. It also adds a visual indicator of the memory buffer usage in the editor. This usage is on a logarithmic scale, where ~1% utilization of the hardware buffer will appear as ~14% usage, weighting the lower values much more highly so that the user can easily tell when the buffer is filling up.
Fixes #9
Fixes #27
This PR also attempts to work on #30, by attaching the
DigitalIOdevice events to theMemoryMonitordata stream. However, this is a fairly naive implementation and has not been thoroughly tested. This is meant as a proof of concept to ensure that we can do what we want to do, and the full functionality will be fleshed out at a later time in another PR. Adding the Breakout Board is a priority for this plugin to be fully testable.