Add block read size functionality #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Persistent heartbeat device is added in version 2.x of the breakout board firmware, check for this - Return immediately if there are errors configuring hardware
- Requires the Onix FMC Host to be major version 1.x - Refactor to break up large methods into smaller chunks that are more transparent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the block read size by adding a UI element in the editor to change it. Also cleans up some of the debug statements for read frame/write frame size, and shifts around some other UI elements to make space.
Fixes #72
Default block read size has been changed from 2048 to 4096.
This PR also gives the added bonus of seeming to fix the memory buffer issue when streaming multiple Neuropixels probes. Previously, when it was set to 2048, the buffer would unpredictably but noticeably increase over time. Setting the block read size to 4096 appears to fix this behavior, or at the very least make it a much more rare occurrence.
Due to upcoming changes in the breakout board firmware, this PR also checks the firmware version to enforce that only firmware v1.x of the Onix FMC Host is valid for this plugin