chore(deps): replace archived gopkg.in/yaml.v3 with go.yaml.in/yaml/v3#240
Merged
beeme1mr merged 4 commits intoopen-feature:mainfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the project from the archived gopkg.in/yaml.v3 dependency to the official go.yaml.in/yaml/v3 fork and updates several other module dependencies. Feedback suggests adding a replace directive in go.mod to ensure that transitive dependencies are also forced to use the new YAML module version, preventing version duplication in the dependency graph.
The gopkg.in/yaml.v3 module (go-yaml/yaml) has been archived. Switch the direct dependency to the official yaml org maintained fork at go.yaml.in/yaml/v3. The remaining indirect reference to gopkg.in/yaml.v3 is pulled in transitively via github.com/wk8/go-ordered-map/v2 and is outside the control of this repository. Fixes open-feature#190 Made-with: Cursor Signed-off-by: Menelik Zafir <mzafir@launchdarkly.com>
4a7fd7e to
afc1c52
Compare
beeme1mr
approved these changes
Apr 27, 2026
sahidvelji
approved these changes
Apr 27, 2026
Member
|
Thanks for your help @professorice |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
gopkg.in/yaml.v3module (go-yaml/yaml) has been archived. This PR switches the direct dependency to the official yaml org maintained fork atgo.yaml.in/yaml/v3.go.mod: replaced directgopkg.in/yaml.v3 v3.0.1withgo.yaml.in/yaml/v3 v3.0.4(which was already present as an indirect dependency, so the upgrade pins to a versiongo mod tidyalready trusted).internal/cmd/compare.go: updated the import path. Dropped the redundantyamlalias since the new module's package is still namedyaml.go.sum: regenerated viago mod tidy.The remaining indirect reference to
gopkg.in/yaml.v3is pulled in transitively viagithub.com/invopop/jsonschema->github.com/wk8/go-ordered-map/v2and is outside the control of this repository — it will go away once those upstreams migrate.Fixes #190
Test plan
go mod tidyis cleango build ./...succeedsgo test ./...passesmake cipasses locally (fmt, lint, test, verify-generate)Made with Cursor