fix: Peribolos improvements #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues have been identified after the merge.
1. although we call us openFeature the Orgaization ID is `open-feature`
and the directory name is actually used as an ID
2. The verification via PR check was a great idea, but has a downside.
we do not want to share such a powerful token with non members.
therefore i deactivate the pr verification for non forks with
peribolos.
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
beeme1mr
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues have been identified after the merge.
although we call ourselves
openFeaturethe Organization ID isopen-feature, and the directory name is used as an IDThe verification via PR check was a great idea but has a downside. We want to keep such a powerful token private from non-members. therefore I deactivate the pr verification for non-forks with peribolos.