fix: old provider not shutting down when the new provider fails to initialize#98
Merged
Conversation
…tialize. Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the ProviderRepository to unconditionally shut down the old provider during initialization, regardless of whether the new provider successfully reaches a ready state. Correspondingly, the test suite has been updated to verify that the old provider is indeed shut down even when the new provider's initialization fails. I have no feedback to provide.
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
Signed-off-by: NeaguGeorgiana23 <neagugeorgiana@google.com>
oxddr
approved these changes
May 12, 2026
toddbaert
approved these changes
May 26, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Ensures that a displaced feature provider is always shut down when a new provider is set, preventing resource leaks when the new provider fails to initialize.
Previously, the old provider was removed from the internal repository map immediately upon setting a new one, but
Shutdown()was only called if the new provider successfully initialized. If the new provider'sInit()failed, the old provider remained active but unreferenced, leaking its resources.Related Issues
Fixes #69