chore: development to main

.github/workflows/contributor-workflow.yml

@@ -16,98 +16,141 @@ jobs:
   analyze-core:
     name: Analyze Core Dart Server SDK
     runs-on: ubuntu-latest
+
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
 
       - name: Setup Dart
         uses: dart-lang/setup-dart@v1
-        with:
-          dart-version: stable
+        # with:
+        #   sdk: stable   # (optional; stable is the default)
+
+      # Find the Dart package root (directory that has pubspec.yaml).
+      - name: Locate package root
+        id: pkg
+        shell: bash
+        run: |
+          set -euo pipefail
+          # Prefer repo root if it has a pubspec.yaml, otherwise take the first match.
+          if [[ -f "pubspec.yaml" ]]; then
+            echo "dir=." >> "$GITHUB_OUTPUT"
+          else
+            PKG_DIR=$(git ls-files | grep -E '(^|/)(pubspec\.yaml)$' | head -n 1 | xargs -r dirname)
+            if [[ -z "${PKG_DIR:-}" ]]; then
+              echo "No pubspec.yaml found in repository." >&2
+              exit 1
+            fi
+            echo "dir=$PKG_DIR" >> "$GITHUB_OUTPUT"
+          fi
+          echo "Using package dir: $(cat $GITHUB_OUTPUT)"
 
       - name: Install Dependencies
+        working-directory: ${{ steps.pkg.outputs.dir }}
         run: |
           echo "Installing dependencies for core SDK..."
-          if ! dart pub get; then
-            echo "❌ Failed to install dependencies for the core SDK. Exiting..."
-            exit 1
-          fi
+          dart pub get
 
       - name: Check for Outdated Dependencies
+        working-directory: ${{ steps.pkg.outputs.dir }}
         run: |
           echo "Checking for outdated dependencies..."
           dart pub outdated || true
 
-      - name: Run Static Analysis
+      - name: Run Static Analysis (capture & show)
+        id: analyze
+        working-directory: ${{ steps.pkg.outputs.dir }}
+        shell: bash
         run: |
+          set -o pipefail
           echo "Running static analysis for core SDK..."
-          if ! dart analyze lib/ > analysis_report.txt 2> error_log.txt; then
-            echo "❌ Static analysis failed with errors. See details below:"
-            cat error_log.txt
-            exit 1
+          # Write both stdout and stderr to files while also echoing to the log.
+          # Keep stdout and stderr separate so we can categorize later.
+          # stdout -> analysis_report.txt, stderr -> error_log.txt
+          { dart analyze lib/ | tee analysis_report.txt; } 2> >(tee error_log.txt >&2)
+          STATUS=${PIPESTATUS[0]}
+          if [[ $STATUS -ne 0 ]]; then
+            echo "❌ Static analysis failed. See error_log.txt below:"
+            sed -n '1,200p' error_log.txt || true
           else
             echo "✅ Static analysis completed successfully. No critical errors found."
           fi
+          echo "status=$STATUS" >> "$GITHUB_OUTPUT"
+          exit $STATUS || true  # Don’t fail the step here; allow categorization + artifacts.
 
       - name: Categorize and Count Analysis Results
+        if: always()
+        working-directory: ${{ steps.pkg.outputs.dir }}
+        shell: bash
         run: |
           echo "Categorizing analysis results..."
-
-          grep -i "info" analysis_report.txt > info_report.txt || echo "No informational messages found."
-          grep -i "warning" analysis_report.txt > warning_report.txt || echo "No warnings found."
-          grep -i "error" analysis_report.txt > error_report.txt || echo "No errors found."
+          touch analysis_report.txt error_log.txt
+          # Create categorized files (empty if none)
+          grep -i "info"    analysis_report.txt > info_report.txt    || true
+          grep -i "warning" analysis_report.txt > warning_report.txt || true
+          grep -i "error"   analysis_report.txt > error_report.txt   || true
 
           INFO_COUNT=$(wc -l < info_report.txt || echo 0)
           WARNING_COUNT=$(wc -l < warning_report.txt || echo 0)
           ERROR_COUNT=$(wc -l < error_report.txt || echo 0)
 
+          echo ""
           echo "Summary of analysis results:"
           echo "Informational messages: $INFO_COUNT"
           echo "Warnings: $WARNING_COUNT"
           echo "Errors: $ERROR_COUNT"
           echo ""
 
-          if [[ $INFO_COUNT -gt 0 ]]; then
-            echo "Informational messages:"
-            cat info_report.txt
-            echo ""
-          fi
           if [[ $WARNING_COUNT -gt 0 ]]; then
-            echo "Warnings:"
-            cat warning_report.txt
-            echo ""
+            echo "Warnings (first 200 lines):"
+            sed -n '1,200p' warning_report.txt
           fi
+
           if [[ $ERROR_COUNT -gt 0 ]]; then
-            echo "Errors:"
-            cat error_report.txt
             echo ""
+            echo "Errors (first 200 lines):"
+            sed -n '1,200p' error_report.txt
           fi
 
       - name: Identify Specific Commits for Issues
+        if: always()
+        working-directory: ${{ steps.pkg.outputs.dir }}
+        shell: bash
         run: |
-          echo "Identifying specific commits for issues in the core SDK..."
-
-          while IFS= read -r line; do
-            file=$(echo $line | awk -F ':' '{print $1}')
-            if [[ -n "$file" ]]; then
-              git_log=$(git log -n 1 --pretty=format:"%h by %an <%ae>" -- "$file")
+          echo "Identifying specific commits for files mentioned by analyzer..."
+          # Collect .dart file paths mentioned by analyzer; tolerate empty sets
+          FILES=$(awk -F: '{print $1}' analysis_report.txt | grep -E '\.dart$' | sort -u || true)
+
+          if [[ -z "$FILES" ]]; then
+            echo "No files with issues were reported by the analyzer."
+            exit 0
+          fi
+
+          for file in $FILES; do
+            if [[ -f "$file" ]]; then
+              git_log=$(git -C "$GITHUB_WORKSPACE" log -n 1 --pretty=format:"%h by %an <%ae>" -- "$file" || true)
               echo "File: $file"
-              echo "Issue: $line"
-              echo "Commit: $git_log"
-            else
-              echo "No file information could be extracted for: $line"
+              echo "Last change: ${git_log:-unknown}"
+              echo ""
             fi
-          done < analysis_report.txt
+          done
 
       - name: Upload Analysis Artifacts
         if: always()
         uses: actions/upload-artifact@v4
         with:
           name: core-sdk-analysis
           path: |
-            dart-server-sdk-openfeature/analysis_report.txt
-            dart-server-sdk-openfeature/error_log.txt
-            dart-server-sdk-openfeature/info_report.txt
-            dart-server-sdk-openfeature/warning_report.txt
-            dart-server-sdk-openfeature/error_report.txt
-          retention-days: 7
+            ${{ steps.pkg.outputs.dir }}/analysis_report.txt
+            ${{ steps.pkg.outputs.dir }}/error_log.txt
+            ${{ steps.pkg.outputs.dir }}/info_report.txt
+            ${{ steps.pkg.outputs.dir }}/warning_report.txt
+            ${{ steps.pkg.outputs.dir }}/error_report.txt
+          retention-days: 7
+
+      # Fail the job if the analyzer actually failed.
+      - name: Fail if analyzer failed
+        if: ${{ steps.analyze.outputs.status != '0' }}
+        run: |
+          echo "❌ Failing job because the analyzer returned a non-zero exit code."
+          exit 1

.github/workflows/parent-pipeline.yml

@@ -37,7 +37,6 @@ jobs:
       branch_name: ${{ needs.determine-workflow.outputs.branch_name }}
       event_name: ${{ needs.determine-workflow.outputs.event_name }}
 
-
   #commented out for now, as we are not running coverage on this repo(for testing).
 
   # trigger-coverage:
@@ -55,6 +54,4 @@ jobs:
     uses: ./.github/workflows/contributor-workflow.yml
     with:
       branch_name: ${{ needs.determine-workflow.outputs.branch_name }}
-
       event_name: ${{ needs.determine-workflow.outputs.event_name }}
-

.github/workflows/validation-workflow.yml

@@ -59,7 +59,7 @@ jobs:
           git fetch origin $BASE_BRANCH
 
           # Extract all commit messages excluding auto-generated ones
-          INVALID_COMMITS=$(git log origin/$BASE_BRANCH..HEAD --pretty=format:"%s" \
+          INVALID_COMMITS=$(git log --no merges origin/$BASE_BRANCH..HEAD --pretty=format:"%s" \
             | grep -vE "^(Merge pull request|Initial commit)" \
             | grep -vE "^(Merge remote-tracking branch|Merge pull request)" \
             | grep -vE "^(Merge branch|DCO Remediation|Signed-off-by)" \

lib/client.dart

@@ -112,8 +112,6 @@ class FeatureClient {
             (_metrics.errorCounts[result.errorCode!.name] ?? 0) + 1;
       }
 
-
-
       _metrics.responseTimes.add(DateTime.now().difference(startTime));
       return result.value;
     } catch (e) {
@@ -131,7 +129,6 @@ class FeatureClient {
       return defaultValue;
     } finally {
       // Execute finally hooks
-
       await _hookManager.executeHooks(HookStage.FINALLY, flagKey, context);
     }
   }
@@ -149,8 +146,6 @@ class FeatureClient {
   );
 
   /// Evaluate string flag
-
-
   Future<String> getStringFlag(
     String flagKey, {
     EvaluationContext? context,
@@ -163,8 +158,6 @@ class FeatureClient {
   );
 
   /// Evaluate integer flag
-
-
   Future<int> getIntegerFlag(
     String flagKey, {
     EvaluationContext? context,
@@ -175,9 +168,6 @@ class FeatureClient {
     (ctx) => _provider.getIntegerFlag(flagKey, defaultValue, context: ctx),
     context: context?.attributes,
   );
-
-
-
   /// Evaluate double flag
   Future<double> getDoubleFlag(
     String flagKey, {
@@ -189,10 +179,6 @@ class FeatureClient {
     (ctx) => _provider.getDoubleFlag(flagKey, defaultValue, context: ctx),
     context: context?.attributes,
   );
-
-
-  /// Evaluate object flag
-
   Future<Map<String, dynamic>> getObjectFlag(
     String flagKey, {
     EvaluationContext? context,
@@ -203,10 +189,6 @@ class FeatureClient {
     (ctx) => _provider.getObjectFlag(flagKey, defaultValue, context: ctx),
     context: context?.attributes,
   );
-
-
-  /// Get client metrics
-
   ClientMetrics getMetrics() => _metrics;
 
   /// Access to provider for management operations

lib/feature_provider.dart

@@ -183,7 +183,6 @@ abstract class FeatureProvider {
 abstract class CachedFeatureProvider implements FeatureProvider {
   final ProviderConfig _config;
   final ProviderMetadata _metadata;
-
   ProviderState _state = ProviderState.NOT_READY;
 
   // Provider-level cache
@@ -206,11 +205,6 @@ abstract class CachedFeatureProvider implements FeatureProvider {
   ProviderMetadata get metadata => _metadata;
 
   @override
-
-  ProviderMetadata get metadata => _metadata;
-
-  @override
-
   String get name => _metadata.name;
 
   /// Set provider state
@@ -478,38 +472,32 @@ class InMemoryProvider extends CachedFeatureProvider {
 
     setState(ProviderState.CONNECTING);
 
-
-
     try {
       // Simulate initialization work
       await Future.delayed(Duration(milliseconds: 10));
       setState(ProviderState.READY);
     } catch (e) {
       setState(ProviderState.ERROR);
-
       rethrow;
     }
   }
 
   @override
   Future<void> connect() async {
     if (state == ProviderState.SHUTDOWN) {
-
       throw ProviderException(
         'Cannot connect a shutdown provider',
         code: ErrorCode.PROVIDER_NOT_READY,
       );
     }
 
-
     setState(ProviderState.CONNECTING);
 
     try {
       await Future.delayed(Duration(milliseconds: 10));
       setState(ProviderState.READY);
     } catch (e) {
       setState(ProviderState.ERROR);
-
       rethrow;
     }
   }
@@ -523,11 +511,9 @@ class InMemoryProvider extends CachedFeatureProvider {
   void _checkState() {
     if (state != ProviderState.READY) {
       throw ProviderException(
-t
         'Provider not in READY state: ${state.name}',
         code: ErrorCode.PROVIDER_NOT_READY,
         details: {'currentState': state.name},
-
       );
     }
   }
@@ -723,4 +709,3 @@ t
   }
 }
 
-