feat: run event handlers immediately, add STALE (0.7.0 compliance) #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 78.63% 78.76% +0.12%
==========================================
Files 10 10
Lines 1203 1210 +7
==========================================
+ Hits 946 953 +7
Misses 230 230
Partials 27 27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
changed the title
Member
|
I'll give this a review later today! |
toddbaert
reviewed
Sep 13, 2023
toddbaert
reviewed
Sep 13, 2023
toddbaert
reviewed
Sep 13, 2023
toddbaert
approved these changes
Sep 13, 2023
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
LGTM with the exception of some apparent copy/paste mistakes in test names/logs.
Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
toddbaert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Add a stale state and ensure event handlers run immediately if the associated provider and the state associated with the handle are compatible.
Related Issues
Resolves #220.
Notes
Follow-up Tasks
How to test