feat: Adding simplified evaluation methods #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Kavindu-Dodan
approved these changes
Apr 8, 2024
Contributor
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Approving as I think this adds good syntatic sugar to our client API.
But please consider opinion of our TC (cc - @toddbaert @thomaspoignant @lukas-reining )
lukas-reining
approved these changes
Apr 9, 2024
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
As discussed, I am in of also having an "errorless" API, as we have it in most other SDKs.
The implementation looks good to me.
thomaspoignant
approved these changes
Apr 9, 2024
Member
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
Sounds good to me, it will simplify the usage of the SDK 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Boolean,String,Float,Int, andObjectthat enable simpler usage (no error handling required)Related Issues
Fixes #262
Notes
There seems to be a soft consensus on #262, so this may need to change if the TC deems necessary, but I'm submitting this early for discussion's sake.
Follow-up Tasks
How to test
See additional examples provided.