Skip to content

Conversation

@sahidvelji
Copy link
Contributor

@sahidvelji sahidvelji commented Jun 4, 2025

This PR

Use the standard library maps and slices packages to get a slice of a map's values. The helper function that was defined was meant to be temporary until go.mod was bumped to a version that included maps and slices. Since we just updated the go directive in go.mod to 1.23.0, we can remove the helper function and use the standard library.

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: Sahid Velji <sahidvelji@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (1d5ed74) to head (cc0ca77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   85.69%   85.65%   -0.04%     
==========================================
  Files          20       20              
  Lines        1447     1443       -4     
==========================================
- Hits         1240     1236       -4     
  Misses        186      186              
  Partials       21       21              
Flag Coverage Δ
e2e 85.65% <100.00%> (-0.04%) ⬇️
unit 85.65% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sahidvelji sahidvelji marked this pull request as ready for review June 4, 2025 00:12
@sahidvelji sahidvelji requested review from a team as code owners June 4, 2025 00:12
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, i just have a simple question - but no show stopper ;)

@beeme1mr beeme1mr enabled auto-merge (squash) June 9, 2025 19:05
@beeme1mr beeme1mr merged commit 703c3ef into open-feature:main Jun 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants