-
Notifications
You must be signed in to change notification settings - Fork 62
chore(deps): update testcontainers to v2 #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update testcontainers to v2 #1654
Conversation
Summary of ChangesHello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant upgrade of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates Testcontainers to v2 and cleans up some test annotations. The migration to JUnit 5 assertions and annotations is well-executed. My review includes a few suggestions:
- Removing some unused imports that were added in the test runner classes.
- Making an implicit dependency on
commons-ioexplicit in thepom.xmlto improve project robustness.
Overall, these are good improvements to the test infrastructure.
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Show resolved
Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFileTest.java
Outdated
Show resolved
Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java
Outdated
Show resolved
Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunRpcTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
77680c0 to
40dfe52
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates Testcontainers to version 2, which includes updating related dependencies and migrating to JUnit 5 assertions. The changes also remove some test annotations. My review includes a suggestion to improve the maintainability of the pom.xml by using a property for the Testcontainers version. I've also raised a concern about the removal of the @Isolated annotation, which could potentially lead to test flakiness due to shared static state in tests, and should be carefully considered.
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java
Show resolved
Hide resolved
9bee76c
into
open-feature:renovate/major-testcontainers-java-monorepo
.. and remove some unnecessary test annotations