Skip to content

Conversation

@aepfli
Copy link
Member

@aepfli aepfli commented Nov 21, 2025

.. and remove some unnecessary test annotations

@gemini-code-assist
Copy link

Summary of Changes

Hello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant upgrade of the testcontainers library to version 2, alongside a comprehensive modernization of the test suite. The changes involve updating the core dependency in the pom.xml, migrating JUnit 4 assertions and test annotations to their JUnit 5 counterparts across multiple test files, and refining Cucumber test configurations, including the removal of @Isolated annotations. These updates aim to leverage the latest features and improvements offered by testcontainers and JUnit Jupiter, ensuring the project's testing infrastructure remains current and robust.

Highlights

  • Dependency Update: The testcontainers library has been updated from version 1.21.3 to 2.0.2, including a change in the JUnit Jupiter artifact name from junit-jupiter to testcontainers-junit-jupiter.
  • JUnit 4 to JUnit 5 Migration: Numerous test files have been updated to use JUnit 5 (Jupiter) assertions and annotations, replacing older JUnit 4 org.junit.Assert calls and @Test annotations with their org.junit.jupiter.api equivalents.
  • Test Annotation Refinement: The @Isolated annotation has been removed from several test classes, indicating a potential adjustment in test execution strategy or compatibility with the updated testcontainers version.
  • Cucumber Parallel Execution Configuration: Several Cucumber test runner files have been updated to include imports for parallel execution constants, suggesting an intent to configure or enable parallel test execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates Testcontainers to v2 and cleans up some test annotations. The migration to JUnit 5 assertions and annotations is well-executed. My review includes a few suggestions:

  • Removing some unused imports that were added in the test runner classes.
  • Making an implicit dependency on commons-io explicit in the pom.xml to improve project robustness.

Overall, these are good improvements to the test infrastructure.

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli aepfli force-pushed the deps/upgrade_testcontainers branch from 77680c0 to 40dfe52 Compare November 21, 2025 19:35
@aepfli
Copy link
Member Author

aepfli commented Nov 21, 2025

/gemini review

@aepfli aepfli changed the title deps: update testcontainers to v2 chore(deps): update testcontainers to v2 Nov 21, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates Testcontainers to version 2, which includes updating related dependencies and migrating to JUnit 5 assertions. The changes also remove some test annotations. My review includes a suggestion to improve the maintainability of the pom.xml by using a property for the Testcontainers version. I've also raised a concern about the removal of the @Isolated annotation, which could potentially lead to test flakiness due to shared static state in tests, and should be carefully considered.

@aepfli aepfli changed the base branch from main to renovate/major-testcontainers-java-monorepo November 21, 2025 20:15
@aepfli aepfli merged commit 9bee76c into open-feature:renovate/major-testcontainers-java-monorepo Nov 21, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants