fix: allow flagd-provider cache to be disabled #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I think it would be a good idea to add one test case for this. That's my general rule for discovering any sort of bug - it means a test was probably missing! |
|
It was discovered while working on the integration tests, it's covered there now but I think you're right that it should be covered by a unit test too |
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
force-pushed
the
fix/caching-disabled
branch
from
ee0800e to
df0c049
Compare
Kavindu-Dodan
approved these changes
Jan 17, 2023
toddbaert
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes issue when using flagd-provider with cache disabled.
Related Issues
Notes
Follow-up Tasks
How to test