Skip to content

feat: exposed eventStreamAliveSync to allow application authors to block until event stream is alive #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

feat: exposed eventStreamAliveSync to allow application authors to block until event stream is alive #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00164b
feat: exposed eventStreamAliveSync to allow application authors to bl…
skyerus Jan 18, 2023
9a5670c
further description of getEventStreamAliveSync
skyerus Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public class FlagdProvider implements FeatureProvider, EventStreamCallback {
private int maxEventStreamRetries = DEFAULT_MAX_EVENT_STREAM_RETRIES;

private ReadWriteLock lock = new ReentrantReadWriteLock();
private Object eventStreamAliveSync;

/**
* Create a new FlagdProvider instance.
Expand Down Expand Up @@ -183,6 +184,7 @@ public FlagdProvider() {
this.eventStreamAlive = false;
this.cache = new FlagdCache(cache, maxCacheSize);
this.maxEventStreamRetries = maxEventStreamRetries;
this.eventStreamAliveSync = new Object();
this.handleEvents();
}

Expand Down Expand Up @@ -603,6 +605,9 @@ public void setEventStreamAlive(Boolean alive) {
l.lock();
this.eventStreamAlive = alive;
if (alive) {
synchronized (this.eventStreamAliveSync) {
this.eventStreamAliveSync.notify(); // notify any waiters that the event stream is alive
}
// reset attempts on successful connection
this.eventStreamAttempt = 1;
this.eventStreamRetryBackoff = BASE_EVENT_STREAM_RETRY_BACKOFF_MS;
Expand Down Expand Up @@ -630,4 +635,15 @@ public void restartEventStream() throws Exception {

this.handleEvents();
}

/**
* Call .wait() on this to block until the event stream is alive.
* Can be used in instances where the provider being connected to the event stream is a prerequisite
* to execution (e.g. testing). Not necessary for standard usage.
*
* @return eventStreamAliveSync
*/
public Object getEventStreamAliveSync() {
return this.eventStreamAliveSync;
}
}