feat: all executors now create daemon threads to reduce shutdown time

[jarebudev]

This PR

Following on from #1633, where a ConfigurableThreadFactory was introduced to allow Threads created by an Executor to be named and either be created as daemon/non-daemon, this PR now changes the SDK so that all executors will create daemon threads.

Related Issues

Resolves #1580

Notes

Follow-up Tasks

How to test

[gemini-code-assist]

Summary of Changes

Hello @jarebudev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SDK's thread management by configuring all internal ExecutorService instances to use daemon threads. This change is a follow-up to a previous PR that introduced a configurable thread factory, and its primary purpose is to improve application shutdown efficiency by ensuring that background tasks do not prevent the JVM from terminating.

Highlights

• Daemon Threads: All ExecutorService instances within the SDK now utilize ConfigurableThreadFactory to create daemon threads, which helps reduce application shutdown time by allowing the JVM to exit without waiting for these threads to complete.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the threads created by executors in EventProvider and EventSupport to be daemon threads. The goal is to prevent these threads from blocking application shutdown. While this change can improve shutdown behavior in cases where the SDK's shutdown() methods are not called, it introduces a significant risk. Daemon threads can be terminated abruptly by the JVM, without guaranteeing the execution of finally blocks. This could lead to issues like resource leaks (e.g., locks not being released) or incomplete critical operations in event handlers. I've left specific comments in EventProvider.java and EventSupport.java detailing these risks. I recommend reconsidering this change and keeping the threads as non-daemon to enforce proper lifecycle management and ensure that cleanup operations are always executed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (ae69411) to head (d89cbe1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1715      +/-   ##
============================================
+ Coverage     92.11%   93.22%   +1.10%     
- Complexity      614      617       +3     
============================================
  Files            55       55              
  Lines          1446     1446              
  Branches        161      161              
============================================
+ Hits           1332     1348      +16     
+ Misses           68       54      -14     
+ Partials         46       44       -2     

Flag	Coverage Δ
unittests	93.22% <100.00%> (+1.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud