chore: update build and tooling to utilize new java version #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepfli
force-pushed
the
beta/new_java_build
branch
9 times, most recently
from
15ca167 to
ea2ebfe
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
beta/new_java_build
branch
from
ea2ebfe to
9cd20db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1321 +/- ##
============================================
+ Coverage 92.78% 93.23% +0.44%
- Complexity 465 467 +2
============================================
Files 43 43
Lines 1123 1123
Branches 90 90
============================================
+ Hits 1042 1047 +5
+ Misses 53 48 -5
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chrfwow
force-pushed
the
beta/new_java_build
branch
from
4358bb1 to
3691b52
Compare
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
toddbaert
reviewed
Feb 11, 2025
Member
|
The build looks good to me and so do your changes, but I think you are targeting the wrong branch: https://github.com/open-feature/java-sdk/pull/1321/files#r1951674440 |
aepfli
force-pushed
the
beta/new_java_build
branch
from
eb21d1a to
632948c
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
beta/new_java_build
branch
from
632948c to
2159941
Compare
toddbaert
approved these changes
Feb 12, 2025
toddbaert
requested review from
Kavindu-Dodan,
beeme1mr,
justinabrahms and
kinyoklion
lukas-reining
approved these changes
Feb 12, 2025
beeme1mr
approved these changes
Feb 13, 2025
Member
Author
|
#1331 - should solve the failing test issue |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullrequest will change our java version for builds. We still have a verification step with java 8 to ensure that we are not using any kind of wrong api which is part of a different jdk version.
how to test
see open-feature/java-sdk-contrib#1213