-
Notifications
You must be signed in to change notification settings - Fork 59
chore: update node version #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @beeme1mr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the project's Node.js versioning. It moves the .nvmrc
configuration to Node.js v24 and adjusts the CONTRIBUTING.md
to recommend Node.js v20+ for development. This ensures that the project leverages more current Node.js features and benefits from ongoing performance improvements and security updates.
Highlights
- Node.js Version Update: The
.nvmrc
file has been updated to specify Node.js version 24, aligning the project with a more recent runtime environment. - Contribution Guidelines: The
CONTRIBUTING.md
file now recommends Node.js 20+ for contributors, updating the minimum required version for development.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project's Node.js version. The change in .nvmrc
to version 24 is consistent with the engines
field in package.json
. However, the accompanying change in CONTRIBUTING.md
updates the recommended version to 20+
, which is inconsistent with the project's actual requirement of 24+
. I've provided a suggestion to align the documentation. Also, please note that the PR description mentions updates to GitHub Actions, but those changes don't appear to be included in this pull request.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
This PR
.npmrc
node version to v24.npmrc
version in GitHub actionsNotes
Unfortunately, publishing isn't working because the package.json specifies a node version that we aren't currently using for publishing.
https://github.com/open-feature/js-sdk-contrib/actions/runs/17834916002/job/50709535315
Our test matrix still checks older node versions, the
.npmrc
file recommends the latest stable release of Node.