Skip to content

Conversation

jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Oct 21, 2025

Addresses feedback from #1265 (Gemini bot review comments).

Changes

  1. Fixed documentation mismatch: Updated all code examples to use MultiProvider instead of incorrect WebMultiProvider class name

    • packages/web/README.md (4 occurrences)
    • packages/web/src/provider/multi-provider/README.md (4 occurrences)
  2. Removed duplicate error logging: Fixed redundant stack trace logging in hook-executor.ts where errors were being logged twice in both errorHooks and finallyHooks methods

…ror logging

Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
@jonathannorris jonathannorris requested review from a team as code owners October 21, 2025 19:46
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses feedback from a previous review by correcting documentation inaccuracies and optimizing error logging. It updates code examples in the web package's READMEs to use the correct MultiProvider class name, resolving potential developer confusion. Additionally, it removes duplicate stack trace logging in the hook-executor.ts file, reducing log noise and improving clarity when errors occur.

Highlights

  • Documentation Correction: Updated all code examples in packages/web/README.md and packages/web/src/provider/multi-provider/README.md to correctly reference MultiProvider instead of the outdated WebMultiProvider class name.
  • Duplicate Error Logging Removal: Eliminated redundant stack trace logging in hook-executor.ts within both errorHooks and finallyHooks methods, preventing errors from being logged twice.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the documentation to use the MultiProvider class name and removes redundant error logging. My review includes suggestions to make the error logging more robust by adding a check to ensure err.stack exists before passing it to the logger, as it can be undefined.

@jonathannorris jonathannorris added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 18c2719 Oct 21, 2025
11 checks passed
@jonathannorris jonathannorris deleted the fix-multiprovider-docs-and-logging branch October 21, 2025 20:38
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.7.0](web-sdk-v1.6.2...web-sdk-v1.7.0)
(2025-10-21)


### ✨ New Features

* Migrate MultiProvider from js-sdk-contrib
([#1234](#1234))
([8686dbf](8686dbf))


### 🐛 Bug Fixes

* correct MultiProvider class name in docs and remove duplicate error
logging ([#1267](#1267))
([18c2719](18c2719))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants