-
Notifications
You must be signed in to change notification settings - Fork 44
fix: correct MultiProvider class name in docs and remove duplicate error logging #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ror logging Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
Summary of ChangesHello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses feedback from a previous review by correcting documentation inaccuracies and optimizing error logging. It updates code examples in the web package's READMEs to use the correct Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the documentation to use the MultiProvider
class name and removes redundant error logging. My review includes suggestions to make the error logging more robust by adding a check to ensure err.stack
exists before passing it to the logger, as it can be undefined
.
🤖 I have created a release *beep* *boop* --- ## [1.7.0](web-sdk-v1.6.2...web-sdk-v1.7.0) (2025-10-21) ### ✨ New Features * Migrate MultiProvider from js-sdk-contrib ([#1234](#1234)) ([8686dbf](8686dbf)) ### 🐛 Bug Fixes * correct MultiProvider class name in docs and remove duplicate error logging ([#1267](#1267)) ([18c2719](18c2719)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Addresses feedback from #1265 (Gemini bot review comments).
Changes
Fixed documentation mismatch: Updated all code examples to use
MultiProvider
instead of incorrectWebMultiProvider
class namepackages/web/README.md
(4 occurrences)packages/web/src/provider/multi-provider/README.md
(4 occurrences)Removed duplicate error logging: Fixed redundant stack trace logging in
hook-executor.ts
where errors were being logged twice in botherrorHooks
andfinallyHooks
methods