fix: multi-provider hook context management #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing an issue with the MultiProvider where hook contexts and hints were being lost due to copies of the context data being created in the OpenFeature sdk evaluation. Since key evaluation of Maps using objects is done by reference, the lookup of the context during evaluation was failing, leading to errors. Signed-off-by: Mike Kitzman <mdkitzman@gmail.com>
beeme1mr
reviewed
Nov 17, 2025
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Could a test be added to verify the issue has been resolved?
Contributor
Author
Yeah, let me take a look at adding a test for this. |
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Thanks for the PR @mdkitzman!
I see one possible issue.
When accumulating the context in the OpenFeature client in the before hooks, the context was being re-assigned instead of merged. This change ensures that the context is merged correctly, preserving object reference. Signed-off-by: Mike Kitzman <mdkitzman@gmail.com>
jonathannorris
approved these changes
Nov 19, 2025
Member
jonathannorris
left a comment
jonathannorris
left a comment
There was a problem hiding this comment.
This looks like the correct fix to me, assigning the existing object and not creating a new one makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixing an issue with the MultiProvider where hook contexts and hints were being lost due to copies of the context data being created in the OpenFeature sdk evaluation.
Since key evaluation of Maps using objects is done by reference, the lookup of the context during evaluation was failing, leading to errors.
Related Issues
Fixes #1268
Notes
Follow-up Tasks
How to test