Skip to content

refactor: changing vars to vals #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicklasl merged 1 commit into from
Nov 7, 2023
Merged

refactor: changing vars to vals #65

nicklasl merged 1 commit into from
Nov 7, 2023

Conversation

@nicklasl
Copy link
Member

@nicklasl nicklasl commented Nov 6, 2023 •
edited
Loading

Release-As: 0.1.0

This PR

  • Changes a bunch of vars to vals
  • Could definitely be considered a breaking change but since we're not at 1.0 I don't think we should bump major.

@nicklasl
fix: changing vars to vals
115cf28 
BREAKING CHANGE

Signed-off-by: Nicklas Lundin <nicklasl@spotify.com>
@nicklasl nicklasl marked this pull request as ready for review November 7, 2023 08:21
@nicklasl nicklasl changed the title fix: changing vars to vals refactor: changing vars to vals Nov 7, 2023
@nicklasl nicklasl merged commit cdcb2df into main Nov 7, 2023
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
@nicklasl nicklasl deleted the var-to-val-cleanup branch November 7, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vahidlazio vahidlazio vahidlazio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicklasl @vahidlazio