Skip to content

Conversation

@tcarrio
Copy link
Member

@tcarrio tcarrio commented Feb 10, 2023

This PR

  • deprecates support for PHP 7.4
  • includes optional devenv config

Related Issues

Fixes #45

Notes

Follow-up Tasks

Update all providers and hooks in sdk-contrib

How to test

Once the flagd provider is updated we should be able to validate these with integration tests again

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #77 (c7b15ef) into main (29f219f) will not change coverage.
The diff coverage is 96.15%.

❗ Current head c7b15ef differs from pull request most recent head f145901. Consider uploading reports for the commit f145901 to get more accurate results

@@            Coverage Diff            @@
##               main      #77   +/-   ##
=========================================
  Coverage     95.19%   95.19%           
  Complexity      227      227           
=========================================
  Files            40       40           
  Lines           583      583           
=========================================
  Hits            555      555           
  Misses           28       28           
Impacted Files Coverage Δ
src/OpenFeatureClient.php 99.13% <ø> (ø)
src/implementation/hooks/HookContextFactory.php 100.00% <ø> (ø)
src/implementation/provider/AbstractProvider.php 66.66% <ø> (ø)
src/implementation/common/ValueTypeValidator.php 85.71% <87.50%> (ø)
src/implementation/flags/Attributes.php 100.00% <100.00%> (ø)
src/implementation/flags/EvaluationDetails.php 100.00% <100.00%> (ø)
.../implementation/flags/EvaluationDetailsBuilder.php 100.00% <100.00%> (ø)
.../implementation/flags/EvaluationDetailsFactory.php 100.00% <100.00%> (ø)
src/implementation/flags/MutableAttributes.php 88.23% <100.00%> (ø)
src/implementation/flags/NoOpClient.php 100.00% <100.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio tcarrio force-pushed the feat/deprecate-php-7 branch from 1a54b5c to c7b15ef Compare February 10, 2023 05:06
style: apply phpcbf fixes

style: apply fixes for native type hinting mixed array

build: remove php 7 from tool-versions

build: add devenv config

chore: upgrade test-harness to v0.2.2

fix: update AbstractProvider to implement Provider interface

refactor: loosen interface to mixed to allow objects

ci: target latest version of open-feature/sdk
Signed-off-by: Tom Carrio <tom@carrio.dev>

fix: typing for internal providers

Signed-off-by: Tom Carrio <tom@carrio.dev>

refactor: get all typings to a better spot
Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio tcarrio force-pushed the feat/deprecate-php-7 branch from c7b15ef to f145901 Compare February 10, 2023 05:07
@tcarrio tcarrio changed the title Feat/deprecate php 7 feat: deprecate php 7 Feb 10, 2023
@tcarrio tcarrio merged commit 0a9b5b5 into main Feb 10, 2023
tcarrio pushed a commit that referenced this pull request Feb 10, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](1.3.1...1.4.0)
(2023-02-10)


### Features

* deprecate php 7
([#77](#77))
([0a9b5b5](0a9b5b5))


### Bug Fixes

* **deps:** update dependency open-feature/flagd-provider to ^0.3.0
([#70](#70))
([29f219f](29f219f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] Deprecate PHP 7.4 support

2 participants