Skip to content

Conversation

@ajhelsby
Copy link
Contributor

This PR

Improve unit test coverage to ensure spec is followed.

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
@ajhelsby ajhelsby changed the title fix/unit-tests: Improve unit test coverage to ensure spec is followed fix:Unit tests Oct 19, 2022
@ajhelsby ajhelsby changed the title fix:Unit tests fix: Unit tests Oct 19, 2022
@ajhelsby ajhelsby marked this pull request as draft October 19, 2022 10:25
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
@ajhelsby ajhelsby marked this pull request as ready for review October 19, 2022 11:14
…ovided

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #28 (ce41c16) into main (b39cced) will increase coverage by 8.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   85.40%   93.54%   +8.13%     
==========================================
  Files          17       17              
  Lines         281      279       -2     
==========================================
+ Hits          240      261      +21     
+ Misses         41       18      -23     
Flag Coverage Δ
unittests 93.54% <100.00%> (+8.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/hooks/hook_support.py 95.00% <100.00%> (ø)
open_feature/open_feature_client.py 97.01% <100.00%> (+20.20%) ⬆️
open_feature/provider/no_op_provider.py 100.00% <0.00%> (+5.26%) ⬆️
open_feature/open_feature_api.py 100.00% <0.00%> (+13.33%) ⬆️
open_feature/exception/exceptions.py 82.35% <0.00%> (+17.64%) ⬆️
open_feature/open_feature_evaluation_context.py 100.00% <0.00%> (+33.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
…ate_provider_evaluation and move to public method

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>

Signed-off-by: Andrew Helsby <ajhelsby@hotmail.com>
@ajhelsby ajhelsby merged commit df0c033 into main Nov 2, 2022
@ajhelsby ajhelsby deleted the fix/unit-tests branch November 15, 2022 11:48
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
Signed-off-by: Federico Bond <federicobond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants