feat: connection persistance #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustinasrce
force-pushed
the
feature/connection-persistance
branch
from
a07963b to
ae017f1
Compare
Signed-off-by: Augustinas Sueris <augustinas.sueris@vinted.com>
Signed-off-by: Augustinas Sueris <augustinas.sueris@vinted.com>
Signed-off-by: Augustinas Sueris <augustinas.sueris@vinted.com>
Signed-off-by: Augustinas Sueris <augustinas.sueris@vinted.com>
augustinasrce
force-pushed
the
feature/connection-persistance
branch
from
24f627c to
8308617
Compare
maxveldink
requested changes
Jul 30, 2025
Contributor
maxveldink
left a comment
maxveldink
left a comment
There was a problem hiding this comment.
Main reason for the request changes is the customer header passing in the initializer; few other questions for you!
providers/openfeature-go-feature-flag-provider/spec/examples.txt
Outdated
Show resolved
Hide resolved
providers/openfeature-go-feature-flag-provider/lib/openfeature/go-feature-flag/goff_api.rb
Outdated
Show resolved
Hide resolved
providers/openfeature-go-feature-flag-provider/lib/openfeature/go-feature-flag/goff_api.rb
Show resolved
Hide resolved
…e/go-feature-flag/goff_api.rb Co-authored-by: Max VelDink <maxveldink@gmail.com> Signed-off-by: Augustinas <augustinas.sueris@gmail.com>
…/go-feature-flag/goff_api.rb Co-authored-by: Max VelDink <maxveldink@gmail.com> Signed-off-by: Augustinas <augustinas.sueris@gmail.com>
Signed-off-by: Augustinas <augustinas.sueris@gmail.com>
added rspec examples to gitignore Signed-off-by: Augustinas <augustinas.sueris@gmail.com>
thomaspoignant
approved these changes
Jul 30, 2025
Member
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
That sounds good to me 👌
thomaspoignant
pushed a commit
that referenced
this pull request
Jul 30, 2025
🤖 I have created a release *beep* *boop* --- ## [0.1.4](openfeature-go-feature-flag-provider/v0.1.3...openfeature-go-feature-flag-provider/v0.1.4) (2025-07-30) ### ✨ New Features * connection persistance ([#59](#59)) ([3a01a5e](3a01a5e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Zaimwa9
pushed a commit
to Zaimwa9/ruby-sdk-contrib
that referenced
this pull request
Nov 26, 2025
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->
## This PR
By default faraday uses net::http which on each request opens new socket
and does all the handshaking every time. Persistent adapter keeps
connection alive for defined amount of time (30s).
fix for `def initialize(options: {})` since it was incorrect on default
behaviour, it is expected to get Options object not hash.
### Follow-up Tasks
With later PR's I could make this configurable.
---------
Signed-off-by: Augustinas Sueris <augustinas.sueris@vinted.com>
Signed-off-by: Augustinas <augustinas.sueris@gmail.com>
Co-authored-by: Max VelDink <maxveldink@gmail.com>
Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Zaimwa9
pushed a commit
to Zaimwa9/ruby-sdk-contrib
that referenced
this pull request
Nov 26, 2025
…-feature#60) 🤖 I have created a release *beep* *boop* --- ## [0.1.4](open-feature/ruby-sdk-contrib@openfeature-go-feature-flag-provider/v0.1.3...openfeature-go-feature-flag-provider/v0.1.4) (2025-07-30) ### ✨ New Features * connection persistance ([open-feature#59](open-feature#59)) ([3a01a5e](open-feature@3a01a5e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: wadii <wadii.zaim@flagsmith.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
By default faraday uses net::http which on each request opens new socket and does all the handshaking every time. Persistent adapter keeps connection alive for defined amount of time (30s).
fix for
def initialize(options: {})since it was incorrect on default behaviour, it is expected to get Options object not hash.Follow-up Tasks
With later PR's I could make this configurable.