feat: add (optional) serde_json conversion support#45
Merged
sheepduke merged 1 commit intoopen-feature:mainfrom Dec 19, 2023
Merged
feat: add (optional) serde_json conversion support#45sheepduke merged 1 commit intoopen-feature:mainfrom
sheepduke merged 1 commit intoopen-feature:mainfrom
Conversation
Signed-off-by: YUE Daian <sheepduke@gmail.com>
beeme1mr
approved these changes
Dec 18, 2023
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Looks good to me. As a follow up, could you add a short example to the readme? Perhaps in the Develop a provider section.
justinabrahms
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
serde_jsonthat mainly containsimpl TryFrom<serde_json::Value> for Value.Related Issues
Close #18
Notes
Follow-up Tasks
How to test