ci: setup ci for test and lint #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicklas Lundin <nicklasl@spotify.com>
beeme1mr
approved these changes
Aug 24, 2023
fabriziodemaria
added a commit
that referenced
this pull request
Nov 12, 2025
## This PR 1. Fixes possible race conditions detected when running updateEvaluationContextAndWait in parallel 2. Adds AsyncProviderOperationsQueue for safe and optimized processing of background context resolving 3. Fix bug where `ready` could be emitted when a context is set without any provider set 4. Adds `clearProviderAndWait` to complement the same pattern in setProvider and setEvaluationContext ### Notes Stacktrace for the original crash (from point 1 above): ``` Task 22150 Queue : com.apple.root.default-qos.cooperative (concurrent) #0 0x00000001970125c4 in _swift_release_dealloc () #1 0x0000000197013094 in swift::RefCounts<swift::RefCountBitsT<(swift::RefCountInlinedness)1>>::doDecrementSlow<(swift::PerformDeinit)1> () #2 0x00000001129667f8 in __swift_destroy_boxed_opaque_existential_1 () #3 0x000000011296a844 in outlined destroy of EvaluationContext? () #4 0x0000000112975098 in OpenFeatureAPI.updateContext(evaluationContext:) at /Users/XXX/Library/Developer/Xcode/DerivedData/confidence-sdk-swift-XXX/SourcePackages/checkouts/swift-sdk/Sources/OpenFeature/OpenFeatureAPI.swift:187 #5 0x0000000112973690 in closure #1 in closure #1 in closure #1 in OpenFeatureAPI.setEvaluationContextAndWait(evaluationContext:) at /Users/XXX/Library/Developer/Xcode/DerivedData/confidence-sdk-swift-XXX/SourcePackages/checkouts/swift-sdk/Sources/OpenFeature/OpenFeatureAPI.swift:95 #6 0x0000000112975f40 in partial apply for closure #1 in closure #1 in closure #1 in OpenFeatureAPI.setEvaluationContextAndWait(evaluationContext:) () #7 0x00000001129764dc in thunk for @escaping @isolated(any) @callee_guaranteed @async () -> (@out A) () #8 0x0000000112976648 in partial apply for thunk for @escaping @isolated(any) @callee_guaranteed @async () -> (@out A) () ``` --------- Signed-off-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR