Issue488: Fix multiple authors text and avatar alignment #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bebatut could you please review this PR? ❤️ |
bebatut
reviewed
Oct 24, 2022
Gemfile.lock
Outdated
| jekyll-feed (~> 0.9) | ||
| jekyll-seo-tag (~> 2.1) | ||
| minitest (5.16.1) | ||
| nokogiri (1.13.9-arm64-darwin) |
Member
There was a problem hiding this comment.
As in the other Pull Request, could you revent your changes ou this file? Thanks
Contributor
Author
There was a problem hiding this comment.
@bebatut I believe this one is fixed 🙂 and hopefully ready to be approved and merged 😆
| border-radius: 50%; | ||
| margin-left: 0.25em; | ||
| margin-right: 0.25em; | ||
| vertical-align: middle; |
Member
|
Thanks @vasconsaurus for the fixed there |
Contributor
Author
|
@bebatut there were some bumps along the way, but I'm really happy it worked out ok in the end 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #488
What this PR does
This aligns text and avatars by their middle.
How/Why
It was looking a bit messy, so I just added a
vertical-alignmenttopeople-badgeImage of the new behavior 😉