[Fix] Fix demo scripts #1815
Merged
[Fix] Fix demo scripts #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeowZheng
reviewed
Jul 27, 2022
mmseg/apis/inference.py
Outdated
|
|
||
| from mmseg.datasets.transforms import Compose | ||
| from mmseg.models import build_segmentor | ||
| from mmseg.datasets.transforms.compose import Compose |
Collaborator
There was a problem hiding this comment.
Suggested change
| from mmseg.datasets.transforms.compose import Compose | |
| from mmengine.dataset import Compose |
MeowZheng
reviewed
Jul 29, 2022
Comment on lines
+102
to
+104
| draw_gt: bool = True, | ||
| draw_pred: bool = True, | ||
| wait_time: float = 0, |
Collaborator
There was a problem hiding this comment.
Might add draw_gt, draw_pred, and wait_time in docstring
MeowZheng
reviewed
Jul 29, 2022
mmseg/apis/inference.py
Outdated
|
|
||
|
|
||
| def inference_model(model, img): | ||
| def inference_model(model: BaseSegmentor, img): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def inference_model(model: BaseSegmentor, img): | |
| ImagesType = Union[str, np.ndarray, Sequence[str], Sequence[np.ndarray]] | |
| def inference_model(model: BaseSegmentor, img: ImagesType)->Union[SegDataSample, DataSample]: |
MeowZheng
reviewed
Jul 29, 2022
mmseg/apis/inference.py
Outdated
| data = scatter(data, [device])[0] | ||
| else: | ||
| data['img_metas'] = [i.data[0] for i in data['img_metas']] | ||
| data = _preprare_data(img, model) |
Collaborator
There was a problem hiding this comment.
Suggested change
| data = _preprare_data(img, model) | |
| if isinstance(imgs, (list, tuple)): | |
| is_batch = True | |
| else: | |
| imgs = [imgs] | |
| is_batch = False | |
| data = _preprare_data(imgs, model) |
MeowZheng
reviewed
Jul 29, 2022
mmseg/apis/inference.py
Outdated
Comment on lines
93
to
94
|
|
||
| return result |
Collaborator
There was a problem hiding this comment.
Suggested change
| return result | |
| if not is_batch: | |
| return results[0] | |
| else: | |
| return results |
wjkim81
pushed a commit
to wjkim81/mmsegmentation
that referenced
this pull request
Dec 3, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
* [Feature] Add SegVisualizer * change name to visualizer_example * fix inference api * fix video demo and refine inference api * fix * mmseg compose * set default device to cuda:0 * fix import * update dir * rm engine/visualizer ut * refine inference api and docs * rename Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix demo scripts
Modification
inference_model()API