Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@rhc54
Copy link

@rhc54 rhc54 commented May 23, 2016

@bosilca Can you please review? Your patch on the devel mailing list did not apply cleanly to 1.10, so I tried my best to capture things from master.

@rhc54 rhc54 added this to the v1.10.3 milestone May 23, 2016
@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1693/ for details.

@bosilca
Copy link
Member

bosilca commented May 23, 2016

This is indeed an old patch open-mpi/ompi@00300f46. 👍

@rhc54 rhc54 merged commit 62b0ba3 into open-mpi:v1.10 May 23, 2016
@rhc54 rhc54 deleted the cmr10/timer branch May 23, 2016 19:31
@rhc54
Copy link
Author

rhc54 commented May 24, 2016

Not sure of the source of the issue with pthread_atfork on Mellanox - not seeing an issue anywhere else. I will take a look, but don't have much time to spend on it. Suggest that perhaps Mellanox diagnose why their environments are missing it.

@rhc54
Copy link
Author

rhc54 commented May 24, 2016

Built it again just fine on CentOS7, so I suspect indeed that this is an issue of Mellanox not having a pthread library installed. Note also that this was in last night's tarball, and that no MTT failures were reported this morning.

@jladd-mlnx
Copy link
Member

@rhc54 Negative, Ghostrider. We have pthread installed.
$ls -l /usr/include/pthread.h
-rw-r--r-- 1 root root 40491 Nov 5 2013 /usr/include/pthread.h
$ls -l /usr/lib64/libpthread.so
-rw-r--r-- 1 root root 222 Nov 5 2013 /usr/lib64/libpthread.so

Git bisect squarely points to this PR.

@jsquyres
Copy link
Member

jsquyres commented May 24, 2016

@jladd-mlnx See open-mpi/ompi#1699. Do you have someone who can look into this?

@jladd-mlnx
Copy link
Member

@jsquyres I do not. We are trying to get an HPC-X release done this week.

@jladd-mlnx
Copy link
Member

@rhc54 Can you revert this? It's causing all kinds of problems with our QA and we're in a critical release phase with both HPC-X and MOFED.

@bosilca
Copy link
Member

bosilca commented May 24, 2016

I don't know why -lpthread would be required for this patch. It does however need -lrt.

@jsquyres
Copy link
Member

@bosilca See the detailed analysis on open-mpi/ompi#1699

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants