This repository was archived by the owner on Sep 30, 2022. It is now read-only.
osc/rdma: fix typo #1238
Merged
osc/rdma: fix typo #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to increment the total size after checking the local offset not before. This typo causes large allocations with MPI_Win_allocate() to fail. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit open-mpi/ompi@2409024) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
Test FAILed. |
Merged
|
👍 and a |
|
Test PASSed. |
|
@hppritcha I'm good with this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to increment the total size after checking the local offset not
before. This typo causes large allocations with MPI_Win_allocate() to
fail.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit open-mpi/ompi@2409024)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
:bot🏷️bug
:bot:milestone:v2.0.0
:bot:assign: @hppritcha
This is an obvious bug that doesn't appear to occur with smaller memory windows. This needs to be in 2.0.0.