This repository was archived by the owner on Sep 30, 2022. It is now read-only.
configury + btl/openib: fix a typo #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
:bot:assign: @hjelmn |
|
OMPIBot error: Label "but" does not exist. |
|
:bot🏷️bug |
|
Test PASSed. |
|
Note that with this PR, I still get 2 warnings in the openib BTL (admittedly, one is unrelated): |
test for existence of struct ibv_exp_device_attr.exp_atomic_cap. That was previously mistyped struct ibv_exp_device_attr.ext_atomic_cap (back-ported from commit open-mpi/ompi@1b3be0a)
(back-ported from commit open-mpi/ompi@d5a2ac6) Conflicts: opal/mca/btl/openib/btl_openib_component.c
(back-ported from commit open-mpi/ompi@017f242)
ggouaillardet
force-pushed
the
topic/v2.x/openib_exp_atomic_cap
branch
from
09c6ced to
f3149f2
Compare
|
the two warnings were unrelated indeed. i picked some two more commits, and we are good now :bot:nolabel:pushed-back |
|
Test PASSed. |
|
👍 @hppritcha I think this is good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for existence of struct ibv_exp_device_attr.exp_atomic_cap.
That was previously mistyped struct ibv_exp_device_attr.ext_atomic_cap
(back-ported from commit open-mpi/ompi@1b3be0a)