Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@edgargabriel
Copy link
Member

@edgargabriel edgargabriel commented Aug 4, 2016

This fixes a bug reported on the mailing for ompio.
https://www.open-mpi.org/community/lists/users/2016/05/29333.php

:bot:milestone:v2.0.1
:bot🏷️bug
:bot:assign:@ggouaillardet

@ggouaillardet would you mind reviewing this fix, since you did the counterpart in romio314 ? The issue here was that the barrier in file_close was not sufficient, there has to be a barrier in file_set_size as well, since the user test case otherwise had the potential to reset the size to 0 after some processes already wrote some data. It works now for me for both file_write_at and file_write_shared without any issues.

@ompiteam-bot ompiteam-bot added this to the v2.0.1 milestone Aug 4, 2016
@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2026/ for details.

@edgargabriel
Copy link
Member Author

the same hcoll issues on mellanox

19:54:07 --- MCA component coll:hcoll (m4 configuration macro)
19:54:07 checking for MCA component coll:hcoll compile mode... dso
19:54:07 checking hcoll/api/hcoll_api.h usability... yes
19:54:07 checking hcoll/api/hcoll_api.h presence... yes
19:54:07 checking for hcoll/api/hcoll_api.h... yes
19:54:07 looking for library in lib
19:54:07 checking for library containing hcoll_get_version... no
19:54:08 looking for library in lib64
19:54:08 checking for library containing hcoll_get_version... no
19:54:08 configure: error: HCOLL support requested but not found. Aborting
19:54:08 Build step 'Execute shell' marked build as failure

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2027/ for details.

@hppritcha
Copy link
Member

@edgargabriel please assign a reviewer.

@edgargabriel
Copy link
Member Author

I actually did, butit does not show up for whatever reason, lets try again
:bot:assign:@ggouaillardet

@edgargabriel
Copy link
Member Author

bot:assign:@ggouaillardet

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2034/ for details.

@artpol84
Copy link
Contributor

artpol84 commented Aug 6, 2016

bot:mellanox:retest

1 similar comment
@artpol84
Copy link
Contributor

artpol84 commented Aug 6, 2016

bot:mellanox:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/2043/ for details.

@ggouaillardet
Copy link
Contributor

👍

@hppritcha
Copy link
Member

@jsquyres ready to go

@jsquyres jsquyres merged commit 64dd52e into open-mpi:v2.x Aug 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants