This repository was archived by the owner on Sep 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Javadoc fixes #431
Merged
Merged
Javadoc fixes #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missings @params and @throws as well as adding definitions for the @throws tags. Signed-off-by: Nathaniel Graham <ngraham@lanl.gov> Conflicts: ompi/mpi/java/java/Comm.java ompi/mpi/java/java/Datatype.java ompi/mpi/java/java/File.java ompi/mpi/java/java/Freeable.java ompi/mpi/java/java/GraphComm.java ompi/mpi/java/java/Group.java ompi/mpi/java/java/Info.java ompi/mpi/java/java/Intercomm.java ompi/mpi/java/java/Intracomm.java ompi/mpi/java/java/MPI.java ompi/mpi/java/java/Message.java ompi/mpi/java/java/Prequest.java ompi/mpi/java/java/Request.java ompi/mpi/java/java/Status.java ompi/mpi/java/java/Struct.java ompi/mpi/java/java/UserFunction.java ompi/mpi/java/java/Win.java
There are a few places where adding the @param for the variable javadoc wants does not make sense, so I added suppression statements in those areas. Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
Contributor
|
Test FAILed. |
1 similar comment
Contributor
|
Test FAILed. |
Contributor
Author
|
bot:retest |
ompi/mpi/java/java/CartComm.java
Outdated
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is doubled.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doubled?
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, the sentence is repeated.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc fixes. Added missing @params and @throws as well as adding definitions for the
@throws tags. Also added suppression statements in areas where it did not make sense to add
an @param for certain variables.
Commenting fixes
Signed-off-by: Nathaniel Graham ngraham@lanl.gov
@hppritcha @jsquyres
:bot:milestone:v2.0.0
;bot:label:enhancement