Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@nrgraham23
Copy link
Contributor

Javadoc fixes. Added missing @params and @throws as well as adding definitions for the
@throws tags. Also added suppression statements in areas where it did not make sense to add
an @param for certain variables.

Commenting fixes

Signed-off-by: Nathaniel Graham ngraham@lanl.gov

@hppritcha @jsquyres

:bot:milestone:v2.0.0
;bot:label:enhancement

Nathaniel Graham added 2 commits July 28, 2015 11:49
Added missings @params and @throws as well as adding definitions for the @throws tags.

Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>

Conflicts:
	ompi/mpi/java/java/Comm.java
	ompi/mpi/java/java/Datatype.java
	ompi/mpi/java/java/File.java
	ompi/mpi/java/java/Freeable.java
	ompi/mpi/java/java/GraphComm.java
	ompi/mpi/java/java/Group.java
	ompi/mpi/java/java/Info.java
	ompi/mpi/java/java/Intercomm.java
	ompi/mpi/java/java/Intracomm.java
	ompi/mpi/java/java/MPI.java
	ompi/mpi/java/java/Message.java
	ompi/mpi/java/java/Prequest.java
	ompi/mpi/java/java/Request.java
	ompi/mpi/java/java/Status.java
	ompi/mpi/java/java/Struct.java
	ompi/mpi/java/java/UserFunction.java
	ompi/mpi/java/java/Win.java
There are a few places where adding the @param for the variable
javadoc wants does not make sense, so I added suppression statements
in those areas.

Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
@ompiteam-bot ompiteam-bot added this to the v2.0.0 milestone Jul 28, 2015
@lanl-ompi
Copy link
Contributor

Test FAILed.

1 similar comment
@lanl-ompi
Copy link
Contributor

Test FAILed.

@nrgraham23
Copy link
Contributor Author

bot:retest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is doubled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, the sentence is repeated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

jsquyres added a commit that referenced this pull request Jul 30, 2015
@jsquyres jsquyres merged commit d21acb2 into open-mpi:v2.x Jul 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants