This repository was archived by the owner on Sep 30, 2022. It is now read-only.
ROMIO configure looks for lstat in wrong header #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMIO configure looks for lstat in wrong header The ROMIO configure script checks for a declaration of lstat in unistd.h, but, at least on the Linux machines I checked, lstat is in sys/stat.h. (The detection failure led to a linker error when building ROMIO as part of OpenMPI on one of my admittedly strangely configured machines, somehow.) It appears from the man page that either location is possible, so check both. (cherry picked from mpich/mpich@7b8bd055dfdeb) Signed-off-by: Rob Latham <robl@mcs.anl.gov> Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from open-mpi/ompi@80bb41a)
Member
Author
|
:bot:assign: @jsquyres |
|
Test PASSed. |
Member
|
Per open-mpi/ompi#895, can you add a NEWS item citing @wthrowe for finding the issue and submitting it upstream? |
Member
|
Per open-mpi/ompi#895 (comment), the commit is from @wthrowe 👍 |
hppritcha
added a commit
that referenced
this pull request
Sep 28, 2015
ROMIO configure looks for lstat in wrong header
alex-mikheev
pushed a commit
to alex-mikheev/ompi-release
that referenced
this pull request
Nov 11, 2015
opal/crs: clean up parsing code to fix coverity issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROMIO configure looks for lstat in wrong header
The ROMIO configure script checks for a declaration of lstat in
unistd.h, but, at least on the Linux machines I checked, lstat is in
sys/stat.h. (The detection failure led to a linker error when building
ROMIO as part of OpenMPI on one of my admittedly strangely configured
machines, somehow.) It appears from the man page that either location
is possible, so check both.
(cherry picked from mpich/mpich@7b8bd055dfdeb)
Signed-off-by: Rob Latham robl@mcs.anl.gov
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from open-mpi/ompi@80bb41a)