BUILD: allow specifying platform patch_dir from cmd line #652
Conversation
|
:bot:assign: @jsquyres |
|
Test PASSed. |
|
Why use a magic (undocumented) environment variable instead of a CLI option that would be shown in |
|
@jsquyres - please review open-mpi/ompi#992 with proposed approach. |
|
@miked-mellanox I saw open-mpi/ompi#992: it's no different than this PR. My question remains the same: why use a magic (and undocumented) variable instead of a |
|
@jsquyres - I pushed fix with your proposal under open-mpi/ompi#993 only. Once it is IN, will populate it into v1.10 and v2.0 |
|
ohh, specified wrong PR number in master, here is one for review: open-mpi/ompi#993 |
before: patch_dir=$PLATFORM.patches after patch_dir can be specified as ./configure <....> patch_dir=/usr/local/site_ompi_v_x.y_patches/ if not specified - use default
mike-dubman
force-pushed
the
topic/v1.10_build_patch_dir
branch
from
2479aee to
6fc4dd8
Compare
|
@jsquyres - updated all three PRs w/ same fix |
|
Test PASSed. |
|
Ah! Got it -- 993 looks good. Thanks! 👍 |
BUILD: allow specifying platform patch_dir from cmd line
|
Oops. My mistake; I should have had you update the commit message. Doh. :-( |
4 participants
before:
patch_dir=$PLATFORM.patches
after
./configure --with-platform=FILE --with-platform-patch-dir=DIR
if not specified - use default
master commit: open-mpi/ompi#992